feat: add map method to array/bool
#2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
reviewed
Jun 2, 2024
kgryte
reviewed
Jun 2, 2024
kgryte
reviewed
Jun 2, 2024
Signed-off-by: Athan <[email protected]>
kgryte
reviewed
Jun 5, 2024
kgryte
reviewed
Jun 5, 2024
kgryte
reviewed
Jun 5, 2024
kgryte
requested changes
Jun 5, 2024
There was a problem hiding this comment.
@Jaysukh-409 This is looking good. Two main things:
- Need to update the benchmarks.
- Need to add TypeScript docs.
I've already added a basic types/index.d.ts file to @stdlib/array/bool which should now be available on the latest develop. After merge, you should go ahead and add to this PR.
kgryte
added
the
Needs Changes
kgryte
reviewed
Jun 5, 2024
kgryte
reviewed
Jun 5, 2024
kgryte
reviewed
Jun 5, 2024
Signed-off-by: Athan <[email protected]>
kgryte
reviewed
Jun 5, 2024
Signed-off-by: Athan <[email protected]>
aman-095
pushed a commit
to aman-095/stdlib
that referenced
this pull request
Jun 13, 2024
PR-URL: stdlib-js#2292 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>
kgryte
removed
the
Needs Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
mapmethod to prototype ofBooleanArrayRelated Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers