Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/acscd #1904

Merged
merged 2 commits into from
Mar 22, 2024
Merged

feat: add C implementation for math/base/special/acscd #1904

merged 2 commits into from
Mar 22, 2024

Conversation

Rejoan-Sardar
Copy link
Contributor

@Rejoan-Sardar Rejoan-Sardar commented Mar 15, 2024 •
edited
Loading

Resolves #1893 .

Description

What is the purpose of this pull request?

This pull request:

  • add C implementation for math/base/special/acscd

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the [contributing guidelines][contributing].

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 15, 2024
@gunjjoshi gunjjoshi mentioned this pull request Mar 16, 2024
Closed
3 tasks
@Rejoan-Sardar Rejoan-Sardar changed the title feat: add C implementation for math/base/special/acscd feat: add C implementation for math/base/special/acscd Mar 16, 2024
@Planeshifter Planeshifter self-requested a review March 17, 2024 03:41
@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. Needs Review A pull request which needs code review. labels Mar 17, 2024
@kgryte kgryte removed the request for review from Planeshifter March 17, 2024 11:44
This was referenced Mar 17, 2024
Closed
Closed
@Planeshifter Planeshifter self-requested a review March 21, 2024 02:47
@Planeshifter
Apply suggestions from code review
7134beb 
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be in good shape! Will merge once CI has passed.

@Planeshifter Planeshifter merged commit 5de3b76 into stdlib-js:develop Mar 22, 2024
8 checks passed
@Rejoan-Sardar Rejoan-Sardar deleted the acscd branch March 22, 2024 13:55
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Mar 26, 2024
@Rejoan-Sardar Rejoan-Sardar mentioned this pull request Apr 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add C implementation for math/base/special/acscd
4 participants
@Rejoan-Sardar @Planeshifter @kgryte @stdlib-bot