Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/acsc #1887

Merged
merged 2 commits into from
Mar 15, 2024
Merged

feat: add C implementation for math/base/special/acsc #1887

merged 2 commits into from
Mar 15, 2024

Conversation

Rejoan-Sardar
Copy link
Contributor

Resolves #859 .

Description

What is the purpose of this pull request?

This pull request:

  • add C implementation for math/base/special/acsc

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the [contributing guidelines][contributing].

@stdlib-js/reviewers

@Rejoan-Sardar
Copy link
Contributor Author

@Pranavchiku @Planeshifter @kgryte
"Thank you for bringing this to my attention! I understand that there's already an existing pull request addressing a similar implementation, but it seems that it doesn't entirely resolve the issue, especially considering this package's purpose of facilitating the implementation of other C packages. With that in mind, I've gone ahead and implemented the necessary changes. I would greatly appreciate your feedback and review on the adjustments made."

@Planeshifter Planeshifter changed the title feat: add C implementation for math/base/special/acsc feat: add C implementation for math/base/special/acsc Mar 14, 2024
@Rejoan-Sardar Rejoan-Sardar mentioned this pull request Mar 15, 2024
Closed
3 tasks
Pranavchiku
Pranavchiku approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Rejoan-Sardar !

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 15, 2024
@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. Ready To Merge A pull request which is ready to be merged. labels Mar 15, 2024
@Planeshifter Planeshifter merged commit c2239f3 into stdlib-js:develop Mar 15, 2024
8 checks passed
This was referenced Mar 17, 2024
Closed
Closed
@Rejoan-Sardar Rejoan-Sardar mentioned this pull request Apr 1, 2024
Closed
6 tasks
@Planeshifter Planeshifter mentioned this pull request Jun 25, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/acsc
4 participants
@Rejoan-Sardar @Pranavchiku @Planeshifter @stdlib-bot