Skip to content

Commit

Permalink
Improve tests
Browse files Browse the repository at this point in the history
  • Loading branch information
sayanarijit committed Jan 5, 2024
1 parent 9eb7458 commit e309197
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 11 deletions.
18 changes: 9 additions & 9 deletions tests/app/endpoints.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,21 @@ def get_my_uid(uid: user_id):


@ep.response_model(str)
def get_snake(name) -> Optional[str]:
return None
def get_snake(name=None) -> Optional[str]:
return name


def get_snake_legacy(name) -> Optional[str]:
return None
def get_snake_legacy(name=None) -> Optional[str]:
return name


get_snake_legacy.not_found_on_none = True


@ep.login_required
@ep.response_model(str)
def get_secure_snake(site_id, name) -> Optional[str]:
return None
def get_secure_snake(site_id, name=None) -> Optional[str]:
return name


@ep.login_required
Expand All @@ -74,13 +74,13 @@ def process_request(request, body):
return {"body": body, "headers": request.headers}


class RawRequest(BaseModel):
class RawResp(BaseModel):
raw_body: str
headers: Dict[str, str]


@ep.response_model(RawRequest)
def process_raw_request(request):
@ep.response_model(RawResp)
def process_raw_request(request) -> Optional[dict]:
return {"raw_body": request.stream.read().decode(), "headers": request.headers}


Expand Down
13 changes: 11 additions & 2 deletions tests/test_rest.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,15 +156,24 @@ def test_not_found():

headers = {"Authorization": sid}

url = urls.base + "snakes/"
assert requests.get(url).status_code == 404

url = urls.base + "snakes/viper"
assert requests.get(url).status_code == 200

url = urls.base + "snakes-legacy/"
assert requests.get(url).status_code == 404

url = urls.base + "snakes-legacy/viper"
assert requests.get(url).status_code == 404
assert requests.get(url).status_code == 200

url = urls.base + "sites/1/snakes/viper"
url = urls.base + "sites/1/snakes/"
assert requests.get(url, headers=headers).status_code == 404

url = urls.base + "sites/1/snakes/viper"
assert requests.get(url, headers=headers).status_code == 200


def test_site_group_access():
# 1. No group
Expand Down

0 comments on commit e309197

Please sign in to comment.