Update Fork #1
Merged
Update Fork #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation & code styling fixes
Revert the addition of the wrong bin script
… close (not unset) This mocks connect(), sets the internal _conn to an object, then calls close, which should re-set _conn back to null. The getWrappedConnection() call gives us access to _conn, but does NOT trigger a re-connect, since we mocked connect() to do nothing. Ultimately, if _conn is unset, calling getWrappedConnection() will error. If _conn is not set to null, the test will fail. This tests all the cases.
This also simplies the allowed failures for HHVM
Remove HHVM-nightly builds
removed empty line
According to the comment // deleting duplicated foreign keys present on both on the orphanedForeignKey // and the removedForeignKeys from changedTables A check must be had on the $removedForeignKey so it does point on the removed table. Currently it does unset all keys removal even the one pointing on other table.
On the MySQLPlatform::getDropForeignKeySQL table name will not be escaped if the name is passed instead of the object table itself. Since the getLocalTableName use the localTable property the object is always available, there is no reason not to use it.
To fix the following notice-level errors: Notice: Undefined property: Doctrine\DBAL\Connections\MasterSlaveConnection::$_conn in vendor/doctrine/dbal/lib/Doctrine/DBAL/Connections/MasterSlaveConnection.php line 154 Notice: Undefined index: slave in vendor/doctrine/dbal/lib/Doctrine/DBAL/Connections/MasterSlaveConnection.php line 165
Fix undefined notices within MasterSlaveConnection
…ue methods are passed non-null values that are not DateTime instances.
…ne column comment SQL if unsupported
Added support for inline comments for SQLite fixes #1118
Identify retryable transaction errors
…d to override the default database
…tables have their FK constraints properly removed.
Fixed some broken links in the documentation
…column Add test for schemadiff on table with renamed fk column referencing renamed table
Preserve quotation of old column name in ColumnDiff
Quote reserved keywords in TRUNCATE TABLE SQL
Added parameter "default_dbname" to pdo_pgsql driver which can be use…
Fix unnecessary check in DecimalType
Conflicts: lib/Doctrine/DBAL/Platforms/DB2iSeriesPlatform.php
[Oracle] Add support for Easy Connect string as connection parameter
[DB2] Move row number to the end of the field list in query limit/offset modification
Without using ``--list|-l`` you get a too many arguments error. As an example ... ``` [ 15/02/2016 17:45:32 ] [ C:\wamp\www ] >vendor\bin\doctrine-dbal d:re mysql57 mysql [Symfony\Component\Console\Exception\RuntimeException] Too many arguments. dbal:reserved-words [-l|--list [LIST]] [ 15/02/2016 17:47:39 ] [ C:\wamp\www ] >vendor\bin\doctrine-dbal d:re -l mysql57 mysql [Symfony\Component\Console\Exception\RuntimeException] Too many arguments. dbal:reserved-words [-l|--list [LIST]] [ 15/02/2016 17:47:48 ] [ C:\wamp\www ] >vendor\bin\doctrine-dbal d:re -l mysql57 -l mysql Checking keyword violations for mysql57, mysql... There are 5 reserved keyword violations in your database schema: - Table affiliates column key keyword violations: MySQL57, MySQL - Table epos_landing_pages column key keyword violations: MySQL57, MySQL - Table purchase_notifications column trigger keyword violations: MySQL57, MySQL - Table xpermissions column add keyword violations: MySQL57, MySQL - Table xpermissions column delete keyword violations: MySQL57, MySQL ```
Multiple dialects require a --list per dialect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.