[relay] allow flatbuffer fast track + clean up #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulov-t
added a commit
to stayintarkov/StayInTarkov.Client
that referenced
this pull request
Apr 21, 2024
This uses a new method of (de)serializing player state packets. This has been tested over ~15hours of real gameplay with 3 people. It works out-of-the-box for UDP peer-to-peer but requires an update to the nodejs server for TCP Relay (stayintarkov/SIT.Aki-Server-Mod#40). It uses FlatBuffers, which I embedded as source files in the project to avoid adding a new DLL to the release. See image below for numbers: - A) shows the difference in time spent for a median frame. - `SIT.PacketProcessing` measures time spent handling incoming pstate packets. We go from **2.84ms to 0.05ms (-98%)** which makes sense because for this particular packet, workload is mostly deserialization, which we skip entirely with the new system. - `SIT.SendPlayerState` measures time spent sending pstate packets. Here, we go from **2.63ms to 1.52ms (-42%)** which makes sense since we write directly to a buffer instead of creating temp objects to then serialize them. - B) is even more relevant, it compares network usage, processing time relative to script frame time and GC allocation. - Traffic is reduced by **2x to 4x** in general (here **from ~60kb/s to ~17kb/s**). - GC alloc goes **from ~115kb to ~26kb (-77%)** for `SIT.SendPlayerState` and **from ~190kb to ~4kb (-98%)** (!!) for `SIT.PacketProcessing` - script frame time is much smoother and reduced after this patch, we can see a lot less spikes (due to slow `SIT.PacketProcessing` as shown highlighted in light blue) 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the necessary PR to make stayintarkov/StayInTarkov.Client#271 work with TCP Relay.
That's a longer diff than I wanted but everything looked really shiny. Cleaned up in the following ways:
var, useconstif you can, otherwise useletArray.isArrayinstead ofJSON.stringify+x[0] === '['.indexOfwhen possible