Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking change] remove realm #8528

Closed
wants to merge 1 commit into from
Closed

[Breaking change] remove realm #8528

wants to merge 1 commit into from

Conversation

yenda
Copy link
Contributor

@yenda yenda commented Jul 4, 2019 •
edited by StatusWrike
Loading

https://notes.status.im/removing-realm

Steps to test

  • test that all features are working
  • there is no persistence so after logging out, account is lost

status: ready

@yenda yenda requested review from antdanchenko, churik and a team as code owners July 4, 2019 14:58
@auto-assign auto-assign bot removed the request for review from a team July 4, 2019 14:58
@ghost
Copy link

ghost commented Jul 4, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @mandrigin, and @corpetty

@ghost
Copy link

ghost commented Jul 4, 2019 •
edited by yenda
Loading

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-im-auto
Copy link
Member

status-im-auto commented Jul 4, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (108)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 9cb28d6 #1 2019-07-04 15:01:39 ~3 min ios 📄 log
❌ 9cb28d6 #1 2019-07-04 15:02:11 ~3 min macos 📄 log
❌ 9cb28d6 #1 2019-07-04 15:05:45 ~7 min linux 📄 log
❌ 9cb28d6 #1 2019-07-04 15:07:05 ~8 min windows 📄 log
❌ 9cb28d6 #1 2019-07-04 15:10:01 ~11 min android 📄 log
❌ feb2064 #2 2019-07-04 15:10:40 ~5 min ios 📄 log
❌ 858497b #3 2019-07-04 15:23:42 ~8 min ios 📄 log
❌ 858497b #3 2019-07-04 15:24:16 ~8 min android-e2e 📄 log
❌ 858497b #3 2019-07-04 15:31:40 ~16 min android 📄 log
✔️ 858497b #3 2019-07-04 15:31:49 ~16 min linux 📦 App
✔️ fcf7501 #4 2019-07-04 15:34:46 ~9 min ios 📦 ipa
❌ fcf7501 #4 2019-07-04 15:37:17 ~11 min android-e2e 📄 log
✔️ fcf7501 #4 2019-07-04 15:39:13 ~13 min macos 📦 dmg
✔️ fcf7501 #4 2019-07-04 15:47:00 ~21 min linux 📦 App
✔️ fcf7501 #4 2019-07-04 15:52:48 ~27 min windows 📦 exe
✔️ 7fd39f5 #5 2019-07-04 15:59:13 ~9 min ios 📦 ipa
✔️ 7fd39f5 #5 2019-07-04 16:05:10 ~15 min android 📦 apk
✔️ 7fd39f5 #5 2019-07-04 16:05:26 ~15 min android-e2e 📦 apk
✔️ 7fd39f5 #5 2019-07-04 16:05:32 ~15 min macos 📦 dmg
✔️ 7fd39f5 #5 2019-07-04 16:08:04 ~18 min windows 📦 exe
✔️ 7fd39f5 #5 2019-07-04 16:24:00 ~34 min linux 📦 App
❌ 40faa3f #6 2019-07-04 16:28:23 ~31 sec ios 📄 log
❌ 40faa3f #6 2019-07-04 16:28:34 ~44 sec android-e2e 📄 log
❌ 40faa3f #6 2019-07-04 16:28:34 ~43 sec android 📄 log
❌ 30fd7b7 #7 2019-07-04 16:36:49 ~6 min ios 📄 log
❌ 30fd7b7 #7 2019-07-04 16:37:54 ~7 min android 📄 log
❌ 30fd7b7 #7 2019-07-04 16:40:59 ~10 min android-e2e 📄 log
✔️ 30fd7b7 #7 2019-07-04 16:42:55 ~12 min macos 📦 dmg
❌ afe4b2b #8 2019-07-04 16:55:43 ~6 min ios 📄 log
✔️ afe4b2b #8 2019-07-04 16:58:32 ~9 min android 📦 apk
✔️ afe4b2b #8 2019-07-04 17:00:51 ~11 min windows 📦 exe
✔️ afe4b2b #8 2019-07-04 17:00:58 ~11 min macos 📦 dmg
✔️ afe4b2b #8 2019-07-04 17:02:50 ~13 min android-e2e 📦 apk
✔️ afe4b2b #8 2019-07-04 17:06:10 ~17 min linux 📦 App
❌ f12e114 #9 2019-07-05 15:55:42 ~21 sec android 📄 log
❌ f12e114 #9 2019-07-05 15:55:42 ~19 sec linux 📄 log
❌ f12e114 #9 2019-07-05 15:55:43 ~19 sec macos 📄 log
❌ f12e114 #9 2019-07-05 15:55:44 ~22 sec ios 📄 log
❌ f12e114 #9 2019-07-05 15:55:52 ~27 sec windows 📄 log
❌ f12e114 #9 2019-07-05 16:01:30 ~6 min android-e2e 📄 log
❌ 9d79b1d #10 2019-07-05 16:53:56 ~22 sec android 📄 log
❌ 9d79b1d #10 2019-07-05 16:53:56 ~20 sec linux 📄 log
❌ 9d79b1d #10 2019-07-05 16:53:56 ~19 sec macos 📄 log
❌ 9d79b1d #10 2019-07-05 16:53:56 ~21 sec ios 📄 log
❌ 9d79b1d #10 2019-07-05 16:54:07 ~29 sec windows 📄 log
✔️ 9d79b1d #10 2019-07-05 17:03:33 ~10 min android-e2e 📦 apk
❌ d0a76d4 #11 2019-07-05 17:26:51 ~9 min ios 📄 log
✔️ d0a76d4 #11 2019-07-05 17:29:21 ~11 min linux 📦 App
✔️ d0a76d4 #11 2019-07-05 17:30:15 ~12 min windows 📦 exe
✔️ d0a76d4 #11 2019-07-05 17:30:29 ~13 min macos 📦 dmg
✔️ d0a76d4 #11 2019-07-05 17:31:03 ~13 min android 📦 apk
✔️ d0a76d4 #11 2019-07-05 17:31:15 ~13 min android-e2e 📦 apk
❌ c6bc2a3 #12 2019-07-10 10:49:52 ~6 min ios 📄 log
❌ c6bc2a3 #12 2019-07-10 10:54:12 ~10 min linux 📄 log
❌ c6bc2a3 #12 2019-07-10 10:54:18 ~10 min macos 📄 log
❌ c6bc2a3 #12 2019-07-10 10:54:56 ~11 min windows 📄 log
❌ c6bc2a3 #12 2019-07-10 10:56:38 ~13 min android 📄 log
❌ c6bc2a3 #12 2019-07-10 10:56:41 ~13 min android-e2e 📄 log
❌ a580137 #13 2019-07-10 11:04:56 ~7 min ios 📄 log
✔️ a580137 #13 2019-07-10 11:08:19 ~10 min linux 📦 App
✔️ a580137 #13 2019-07-10 11:09:48 ~12 min macos 📦 dmg
✔️ a580137 #13 2019-07-10 11:10:53 ~13 min android 📦 apk
✔️ a580137 #13 2019-07-10 11:11:15 ~13 min android-e2e 📦 apk
✔️ a580137 #13 2019-07-10 11:11:47 ~14 min windows 📦 exe
❌ b28597e #15 2019-07-29 08:44:50 ~7 min ios 📄 log
❌ b28597e #15 2019-07-29 08:47:33 ~10 min android 📄 log
✔️ b28597e #15 2019-07-29 08:49:09 ~11 min macos 📦 dmg
❌ b28597e #16 2019-07-29 08:50:33 ~13 min android-e2e 📄 log
✔️ b28597e #15 2019-07-29 08:51:36 ~14 min linux 📦 App
✔️ b28597e #15 2019-07-29 08:52:37 ~15 min windows 📦 exe
❌ 4986548 #16 2019-07-29 09:07:54 ~7 min ios 📄 log
❌ 4986548 #17 2019-07-29 09:10:55 ~10 min android-e2e 📄 log
✔️ 4986548 #16 2019-07-29 09:13:15 ~12 min macos 📦 dmg
✔️ 4986548 #16 2019-07-29 09:14:01 ~13 min linux 📦 App
✔️ 4986548 #16 2019-07-29 09:15:06 ~14 min windows 📦 exe
✔️ 4986548 #16 2019-07-29 09:16:25 ~15 min android 📦 apk
❌ 05c9e17 #17 2019-07-29 13:22:14 ~6 min ios 📄 log
❌ 187e184 #18 2019-07-29 13:30:04 ~7 min ios 📄 log
✔️ 187e184 #18 2019-07-29 13:35:08 ~12 min macos 📦 dmg
✔️ 187e184 #18 2019-07-29 13:36:14 ~13 min linux 📦 App
✔️ 187e184 #18 2019-07-29 13:36:44 ~13 min windows 📦 exe
✔️ 187e184 #19 2019-07-29 13:36:50 ~14 min android-e2e 📦 apk
✔️ 187e184 #18 2019-07-29 13:41:45 ~18 min android 📦 apk
❌ 4bab78b #19 2019-07-30 12:08:02 ~1 min android 📄 log
❌ 4bab78b #20 2019-07-30 12:08:07 ~2 min android-e2e 📄 log
❌ 711ec6b #20 2019-07-30 12:13:10 ~23 sec android 📄 log
❌ 711ec6b #20 2019-07-30 12:13:10 ~21 sec linux 📄 log
❌ 711ec6b #20 2019-07-30 12:13:17 ~28 sec ios 📄 log
❌ 711ec6b #20 2019-07-30 12:13:17 ~26 sec windows 📄 log
❌ 711ec6b #20 2019-07-30 12:13:20 ~29 sec macos 📄 log
❌ a183490 #21 2019-07-30 12:27:30 ~7 min ios 📄 log
❌ a183490 #21 2019-07-30 12:29:13 ~8 min windows 📄 log
✔️ a183490 #21 2019-07-30 12:32:57 ~12 min macos 📦 dmg
✔️ a183490 #21 2019-07-30 12:34:25 ~13 min linux 📦 App
✔️ a183490 #21 2019-07-30 12:35:08 ~14 min android 📦 apk
✔️ a183490 #22 2019-07-30 12:39:09 ~18 min android-e2e 📦 apk
❌ e1ff769 #22 2019-07-30 13:23:09 ~5 min ios 📄 log
❌ e1ff769 #23 2019-07-30 13:25:08 ~7 min android-e2e 📄 log
❌ e1ff769 #22 2019-07-30 13:29:04 ~11 min android 📄 log
✔️ e1ff769 #22 2019-07-30 13:29:14 ~11 min macos 📦 dmg
✔️ e1ff769 #22 2019-07-30 13:29:55 ~12 min linux 📦 App
✔️ e1ff769 #22 2019-07-30 13:30:58 ~13 min windows 📦 exe
❌ e99a611 #23 2019-07-30 14:04:29 ~6 min ios 📄 log
❌ e99a611 #24 2019-07-30 14:10:05 ~12 min android-e2e 📄 log
✔️ e99a611 #23 2019-07-30 14:11:22 ~13 min linux 📦 App
✔️ e99a611 #23 2019-07-30 14:15:18 ~17 min macos 📦 dmg
✔️ e99a611 #23 2019-07-30 14:17:14 ~19 min windows 📦 exe
❌ e99a611 #23 2019-07-30 14:19:24 ~21 min android 📄 log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 1e59bc7 #24 2019-07-30 17:07:30 ~7 min ios 📄 log
✔️ 1e59bc7 #24 2019-07-30 17:13:02 ~12 min windows 📦 exe
✔️ 1e59bc7 #24 2019-07-30 17:14:02 ~13 min macos 📦 dmg
✔️ 1e59bc7 #24 2019-07-30 17:16:17 ~15 min linux 📦 App
❌ 1e59bc7 #25 2019-07-30 17:37:20 ~36 min android-e2e 📄 log
✔️ 1e59bc7 #24 2019-07-30 17:44:41 ~44 min android 📦 apk
❌ d89ef58 #25 2019-08-20 16:54:27 ~7 min ios 📄 log
❌ d89ef58 #26 2019-08-20 16:55:01 ~8 min android-e2e 📄 log
❌ d89ef58 #25 2019-08-20 16:55:09 ~8 min android 📄 log
❌ d89ef58 #26 2019-09-04 16:12:35 ~19 sec ios 📄 log

@yenda yenda requested a review from vkjr as a code owner July 4, 2019 15:04
@ghost
Copy link

ghost commented Jul 4, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @mandrigin, and @corpetty

@ghost
Copy link

ghost commented Jul 4, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @mandrigin, and @corpetty

@ghost
Copy link

ghost commented Jul 4, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @mandrigin, and @corpetty

@ghost
Copy link

ghost commented Jul 4, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @mandrigin, and @corpetty

@yenda yenda force-pushed the remove-realm branch 2 times, most recently from 30fd7b7 to afe4b2b Compare July 4, 2019 16:48
@jakubgs
Copy link
Member

jakubgs commented Jul 5, 2019

Interesting:

ld: library not found for -lTcpSockets

This error looks very much like what I'm getting in #7479, but there it's React:

ld: library not found for -lReact

I wonder if you have any idea how to solve this. It seems to be related to how Xcode links libraries, but no matter how much I messed around with those settings in Xcode I couldn't fix it, but that's probably because I'm not that familiar with iOS development.

@yenda
Copy link
Contributor Author

yenda commented Jul 5, 2019 •
edited
Loading

@jakubgs I removed some library and didn't clean up the pods because I don't care about iOS for this experiment. In this case it's missing react-native-tcp which I removed

@yenda yenda force-pushed the remove-realm branch 2 times, most recently from 9d79b1d to d0a76d4 Compare July 5, 2019 17:17
@yenda yenda changed the title [experiment] remove realm [Breaking change] remove realm Jul 9, 2019
@ghost
Copy link

ghost commented Jul 9, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@yenda yenda requested review from a team July 9, 2019 12:35
@ghost
Copy link

ghost commented Jul 29, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@flexsurfer flexsurfer mentioned this pull request Jul 29, 2019
Closed
@ghost
Copy link

ghost commented Jul 29, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@yenda yenda mentioned this pull request Jul 29, 2019
Closed
@ghost
Copy link

ghost commented Jul 29, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

1 similar comment
@ghost
Copy link

ghost commented Jul 30, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@ghost
Copy link

ghost commented Jul 30, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@ghost
Copy link

ghost commented Jul 30, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

1 similar comment
@ghost
Copy link

ghost commented Jul 30, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@flexsurfer
Copy link
Member

@yenda , @pombeirp says if you change deps you have to run make nix-upgrade-npm, just in case

@ghost
Copy link

ghost commented Jul 30, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@yenda
Copy link
Contributor Author

yenda commented Jul 30, 2019

@flexsurfer only for desktop, error is just caused by the fact that I removed react as a dependency, got cocky here :D

@ghost
Copy link

ghost commented Jul 30, 2019

mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@pedropombeiro
Copy link
Contributor

pedropombeiro commented Aug 1, 2019 •
edited
Loading

@yenda , @pombeirp says if you change deps you have to run make nix-upgrade-npm, just in case

@flexsurfer, sorry for misleading you, after a week of vacation I forgot that I had made some improvements before merging Reproducible Android builds PR that don't require that for mobile.

@ghost
Copy link

ghost commented Aug 20, 2019

desktop_files/yarn.lock and mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@yenda yenda closed this Sep 4, 2019
@ghost
Copy link

ghost commented Apr 29, 2020

desktop_files/yarn.lock and mobile_files/yarn.lock changed. Pinging @jakubgs and @corpetty

@jakubgs jakubgs deleted the remove-realm branch May 12, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubgs jakubgs Awaiting requested review from jakubgs jakubgs is a code owner

@pedropombeiro pedropombeiro Awaiting requested review from pedropombeiro

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@yenda @status-im-auto @jakubgs @jeluard @gravityblast @oskarth @rachelhamlin @flexsurfer @pedropombeiro