Make the information sharing screen usable on tiny screens.

[mandrigin]

e.g. an iPhone app on an iPad
This doesn't make it pretty, just usable.

Steps to test:

• Open Status iOS on an iPad
• Expect to be able to pass the information sharing screen

status: ready

[jeluard]

Doesn't that conflict with #4655 ?

[mandrigin]

@jeluard nope. restricting our app to iPhone-only won't really restring it from being installed launched on an iPad. In that case, it will appear in a tiny window in the centre of the screen. This window has exactly iPhone 4 dimensions. I tested our UI there and this was the only unusable screen I found, so I fixed that :)

[mandrigin]

before

after

[jeluard]

@mandrigin Right but we don't intend to support iPad anyway.
I guess it's not an intrusive change so doesn't really matter.

[status-comment-bot]

branch PR-4658:
apk uploaded to https://i.diawi.com/2vSWsi
ipa uploaded to https://i.diawi.com/peUAbC

Install - Diawi - Development and In-house Apps Wireless Installation

Install - Diawi - Development and In-house Apps Wireless Installation

[statustestbot]

72% of end-end tests have passed

Total executed tests: 29
Failed tests: 8
Passed tests: 21

Failed tests (8)

Click to expand

1. test_send_eth_from_wallet_sign_now

Tap on SignTransactionButton Looking for GotItButton E selenium.common.exceptions.NoSuchElementException: Message: 'GotItButton' is not found on screen, using: 'accessibility id:got-it-button' Device sessions: Device 1

2. test_send_eth_to_request_from_wallet

Wait for GotItButton Looking for GotItButton E selenium.common.exceptions.NoSuchElementException: Message: 'GotItButton' is not found on screen, using: 'accessibility id:got-it-button' Device sessions: Device 1 Device 2

3. test_delete_1_1_chat

Wait for GotItButton Looking for GotItButton E selenium.common.exceptions.NoSuchElementException: Message: 'GotItButton' is not found on screen, using: 'accessibility id:got-it-button' Device sessions: Device 1

4. test_wallet_error_messages

Tap on SignTransactionButton Looking for full text: 'Wrong password' E Failed: Wrong password error did not appear Device sessions: Device 1

5. test_transaction_send_command_one_to_one_chat

Wait for GotItButton Looking for GotItButton E selenium.common.exceptions.NoSuchElementException: Message: 'GotItButton' is not found on screen, using: 'accessibility id:got-it-button' Device sessions: Device 1

6. test_transaction_send_command_wrong_password

Tap on SignTransactionButton Looking for full text: 'Wrong password' E selenium.common.exceptions.TimeoutException: Message: 'BaseElement' is not found on screen, using: 'xpath://*[@text="Wrong password"]', during '20' seconds Device sessions: Device 1

7. test_send_eth_to_request_in_one_to_one_chat

Wait for GotItButton Looking for GotItButton E selenium.common.exceptions.NoSuchElementException: Message: 'GotItButton' is not found on screen, using: 'accessibility id:got-it-button' Device sessions: Device 1 Device 2

8. test_send_stt_from_wallet_via_enter_recipient_address

Tap on SignTransactionButton Looking for GotItButton E selenium.common.exceptions.NoSuchElementException: Message: 'GotItButton' is not found on screen, using: 'accessibility id:got-it-button' Device sessions: Device 1

Passed tests (21)

Click to expand

1. test_sign_transaction_twice

Device sessions: Device 1

2. test_swipe_and_delete_1_1_chat

Device sessions: Device 1

3. test_one_to_one_chat_messages

Device sessions: Device 1 Device 2

4. test_copy_and_paste_messages

Device sessions: Device 1

5. test_send_transaction_from_daap

Device sessions: Device 1

6. test_faucet_console_command

Device sessions: Device 1

7. test_username_and_profile_picture_in_chats

Device sessions: Device 1 Device 2

8. test_open_transaction_on_etherscan

Device sessions: Device 1

9. test_incorrect_password

Device sessions: Device 1

10. test_backup_seed_phrase_and_recover_account

Device sessions: Device 1

11. test_offline_messaging_1_1_chat

Device sessions: Device 1 Device 2

12. test_contact_profile_view

Device sessions: Device 1

13. test_public_chat

Device sessions: Device 1 Device 2

14. test_public_chat_management

Device sessions: Device 1 Device 2

15. test_network_switch

Device sessions: Device 1

16. test_browse_link_entering_url_in_dapp_view

Device sessions: Device 1

17. test_profile_picture

Device sessions: Device 1

18. test_switch_users

Device sessions: Device 1

19. test_set_up_wallet

Device sessions: Device 1

20. test_qr_code_and_its_value

Device sessions: Device 1

21. test_sign_message_from_daap

Device sessions: Device 1

[lukaszfryc]

I've checked it on Android Emulator with WVGA (800x480) screen. It looks not bad. No buttons are covered:

[chadyj]

Great changes to make things usable on an iPad!

#4662 will make it optimized :)