-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature #3616] Add 'Selectable' to a Text component on profile and wallet screens #3646
Conversation
…ile and wallet screens
hey @kixi thank you for contribution, is it possible to copy this text? |
Yes copy works on Android AVD on all 3 screens. On iOS I cannot test, because I don't have an environment yet. Need to buy a Mac ... |
100% of end-end tests have passed
Passed tests (16)Click to expand
|
@kixi It's possible to copy values for Contact code and Address so it's OK in iOS (iPhone 7 plus, ios 11.0.3) and Android (Galaxy S6, Android 6.0.1). On the design, there is selection and Copy. I would expect that text selection is shown. |
@kixi Yes, please add selection rectangle as it's on a mockup. Use color for this that we use as button color on the profile page for instance |
Hi, unfortunately I do not have an iOS development right now, so I cannot continue on this issue at the moment. How shall we proceed? Should I withdraw the PR? |
@kixi let's close it for now, fill free to reopen or file new, thanks for your effort |
fixes #3616
Summary:
add selectable to text component on profile and wallet screens
status: ready