Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature #3616] Add 'Selectable' to a Text component on profile and wallet screens #3646

Closed
wants to merge 1 commit into from

Conversation

kixi
Copy link

@kixi kixi commented Mar 21, 2018

fixes #3616

Summary:

add selectable to text component on profile and wallet screens

status: ready

@flexsurfer
Copy link
Member

flexsurfer commented Mar 22, 2018

hey @kixi thank you for contribution, is it possible to copy this text?

@kixi
Copy link
Author

kixi commented Mar 22, 2018

Yes copy works on Android AVD on all 3 screens. On iOS I cannot test, because I don't have an environment yet. Need to buy a Mac ...

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 16
Failed tests: 0
Passed tests: 16

Passed tests (16)

Click to expand
1. test_send_transaction_from_daap
Device sessions:

2. test_send_eth_from_wallet_sign_now
Device sessions:

3. test_one_to_one_chat_messages_and_delete_chat
Device sessions:

4. test_send_eth_to_request_from_wallet
Device sessions:

5. test_contact_profile_view
Device sessions:

6. test_public_chat
Device sessions:

7. test_network_switch
Device sessions:

8. test_group_chat_messages
Device sessions:

9. test_transaction_send_command_one_to_one_chat
Device sessions:

10. test_browse_link_entering_url_in_dapp_view
Device sessions:

11. test_transaction_send_command_wrong_password
Device sessions:

12. test_send_eth_to_request_in_one_to_one_chat
Device sessions:

13. test_send_stt_from_wallet_via_enter_recipient_address
Device sessions:

14. test_send_eth_to_request_in_group_chat
Device sessions:

15. test_transaction_send_command_group_chat
Device sessions:

16. test_send_eth_from_wallet_sign_later
Device sessions:

@annadanchenko annadanchenko self-assigned this Mar 22, 2018
@annadanchenko
Copy link

annadanchenko commented Mar 22, 2018

@kixi It's possible to copy values for Contact code and Address so it's OK in iOS (iPhone 7 plus, ios 11.0.3) and Android (Galaxy S6, Android 6.0.1).
However, when long tap on these fields in iOS then there is no selection shown, only "Copy" is shown. So user does not see what's selected:
10_fb7e2d530c6566841f4b853da0423bec72bf8861_o

On the design, there is selection and Copy. I would expect that text selection is shown.
See video (after 00:40) https://app.testfairy.com/projects/4803590-status/builds/7949991/sessions/4/?accessToken=UkeTixXMtI4-5NRr2sy0uV9fhPA

@denis-sharypin
Copy link

@kixi Yes, please add selection rectangle as it's on a mockup. Use color for this that we use as button color on the profile page for instance
img_3801

@kixi
Copy link
Author

kixi commented Mar 23, 2018

Hi, unfortunately I do not have an iOS development right now, so I cannot continue on this issue at the moment. How shall we proceed? Should I withdraw the PR?

@flexsurfer
Copy link
Member

@kixi let's close it for now, fill free to reopen or file new, thanks for your effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add 'Selectable' to a Text component on profile and wallet screens
7 participants