Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet: Disable long-press feature on tokens in watch-only accounts. #18597 #18598

Merged
merged 8 commits into from
Jan 26, 2024
Merged

Wallet: Disable long-press feature on tokens in watch-only accounts. #18597 #18598

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dae0b86
add functionality
mmilad75 Jan 23, 2024
803e219
Merge branch 'develop' into milad/18597-disable-long-press-on-tokens-…
mmilad75 Jan 24, 2024
cff6afb
update condition
mmilad75 Jan 24, 2024
78d696b
Merge branch 'develop' into milad/18597-disable-long-press-on-tokens-…
mmilad75 Jan 24, 2024
822f0c0
Merge branch 'develop' into milad/18597-disable-long-press-on-tokens-…
mmilad75 Jan 24, 2024
1fa590e
Merge branch 'develop' into milad/18597-disable-long-press-on-tokens-…
mmilad75 Jan 25, 2024
8ba60a3
Merge branch 'develop' into milad/18597-disable-long-press-on-tokens-…
mmilad75 Jan 26, 2024
6ad418d
Merge branch 'develop' into milad/18597-disable-long-press-on-tokens-…
mmilad75 Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/status_im/contexts/wallet/common/token_value/view.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,12 @@

(defn view
[item]
[quo/token-value
(merge item
{:on-long-press
#(rf/dispatch
[:show-bottom-sheet
{:content (fn [] [token-value-drawer item])
:selected-item (fn [] [quo/token-value item])}])})])
(let [{:keys [watch-only?]} (rf/sub [:wallet/current-viewing-account])
on-long-press (when (not watch-only?)
#(rf/dispatch
[:show-bottom-sheet
{:content (fn [] [token-value-drawer item])
:selected-item (fn [] [quo/token-value item])}]))]
[quo/token-value
(merge item
{:on-long-press on-long-press})]))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we can just use

cond-> item
(not watch-only?)
(assoc :on-long-press #(rf...))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Didn't know about this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done