Support unfurling more websites #16040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (3)
|
flexsurfer
approved these changes
Jun 1, 2023
ilmotta
force-pushed
the
feat/unfurl-more-websites
branch
from
c78faa6 to
7a65515
Compare
|
Thanks @ilmotta, PR looks good to me! I've got only one question: 
This is how the same Reddit link looks like on Telegram |
|
@qoqobolo, You're correct, Reddit links don't fully work as of now. This is explained in the related status-go PR, but basically Reddit doesn't provide a thumbnail URL when using OpenGraph, nor with oEmbed. Reddit only gives an HTML to be embedded in webpages, therefore, we will need special handling for Reddit URLs on status-go to extract the thumbnail. |
|
Thank you @ilmotta, PR can be merged! |
ilmotta
force-pushed
the
feat/unfurl-more-websites
branch
from
7a65515 to
c3c1116
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15918
Summary
This PR is only bumping status-go's version to point to the status-go branch in PR status-im/status-go#3530. The full description can be found in status-go or in this PR's issue #15918
Steps to test
Try out some of the newly supported websites, like Reddit, Spotify, YouTube Music. Reddit is not fully supported yet (see the reasons in status-go PR.
status: ready