Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ENS resolving implementation to match what is defined in EIP-1577 #6688

Closed
decanus opened this issue Nov 13, 2018 · 6 comments · Fixed by #7080 or #7359
Closed

Update ENS resolving implementation to match what is defined in EIP-1577 #6688

decanus opened this issue Nov 13, 2018 · 6 comments · Fixed by #7080 or #7359
Assignees
@flexsurfer

Comments

@decanus
Copy link
Contributor

decanus commented Nov 13, 2018

What problem are you trying to solve?

To try and find a better system @Arachnid and I created EIP-1577 that allows for a better representation of network and content addresses.

Describe the solution you'd like

Implement resolution using the new multiaddr field when available.

Issue was copied over from the Metamask repository because of laziness
@flexsurfer flexsurfer self-assigned this Nov 13, 2018
@decanus
Copy link
Contributor Author

decanus commented Nov 13, 2018

There will be changes made to the EIP so implementation should be paused.

@decanus
Copy link
Contributor Author

decanus commented Nov 19, 2018 •
edited by status-github-bot bot
Loading

The EIP has been updated and should be good to go: https://eips.ethereum.org/EIPS/eip-1577

Ethereum Improvement Proposals
Ethereum Improvement Proposals (EIPs) describe standards for the Ethereum platform, including core protocol specifications, client APIs, and contract standards.

This was referenced Nov 25, 2018
Closed
Closed
@flexsurfer flexsurfer mentioned this issue Dec 12, 2018
Merged
jeluard pushed a commit that referenced this issue Dec 13, 2018
@flexsurfer @jeluard
[#6688] Update ENS resolving implementation to match what is defined …
b80230a 
…in EIP-1577

Signed-off-by: Julien Eluard <[email protected]>
@decanus
Copy link
Contributor Author

decanus commented Jan 10, 2019 •
edited by status-github-bot bot
Loading

The EIP has been updated @rachelhamlin, the implementation will need updating too. https://eips.ethereum.org/EIPS/eip-1577

Ethereum Improvement Proposals
Ethereum Improvement Proposals (EIPs) describe standards for the Ethereum platform, including core protocol specifications, client APIs, and contract standards.

@jeluard
Copy link
Contributor

jeluard commented Jan 11, 2019

@decanus Do you mind pointing at what changed specifically?

@flexsurfer flexsurfer reopened this Jan 11, 2019
@decanus
Copy link
Contributor Author

decanus commented Jan 11, 2019

@jeluard The multicodec table used and the way the hashes are encoded.

@rachelhamlin
Copy link
Contributor

thanks @decanus 🙏

@jeluard jeluard mentioned this issue Jan 28, 2019
Merged
@acud acud mentioned this issue Mar 8, 2019
Closed
@acud acud mentioned this issue Mar 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flexsurfer flexsurfer

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jeluard @decanus @flexsurfer @rachelhamlin