Skip to content

Commit

Permalink
chore: upgrade kotlinPluginVersion to 1.9.0
Browse files Browse the repository at this point in the history
### Summary

We need to bump `kotlin` Plugin version to `1.9.0` because the `nixpkgs` upgrade will set default `gradle` version to `8.4`.
`gradle` version `8.4` comes with a base `kotlin` version of `1.9.0` which becomes incompatible with our existing version of `1.7`

Otherwise we get errors like this :

```
e: /Users/siddarthkumar/code/experiments/status-mobile/node_modules/@react-native/
gradle-plugin/src/main/kotlin/com/facebook/react/utils/TaskUtils.kt: (25, 7): Class
'kotlin.collections.CollectionsKt__CollectionsKt' was compiled with an incompatible version of Kotlin.
The binary version of its metadata is 1.9.0, expected version is 1.7.1.
The class is loaded from /nix/store/3a228ppiiljfvsrxyq15h25chmiwsmbh-gradle-8.4/lib/gradle/lib/
kotlin-stdlib-1.9.10.jar!/kotlin/collections/CollectionsKt__CollectionsKt.class
e: /Users/siddarthkumar/code/experiments/status-mobile/node_modules/@react-native/gradle-plugin/
src/main/kotlin/com/facebook/react/utils/TaskUtils.kt: (25, 47): Class
'kotlin.collections.CollectionsKt___CollectionsKt' was compiled with an incompatible version of Kotlin.
The binary version of its metadata is 1.9.0, expected version is 1.7.1.
The class is loaded from /nix/store/3a228ppiiljfvsrxyq15h25chmiwsmbh-gradle-8.4/lib/gradle/lib/
kotlin-stdlib-1.9.10.jar!/kotlin/collections/CollectionsKt___CollectionsKt.class
e: /Users/siddarthkumar/code/experiments/status-mobile/node_modules/@react-native/gradle-plugin/
src/main/kotlin/com/facebook/react/utils/TaskUtils.kt: (27, 12): Class
'kotlin.collections.ArraysKt___ArraysKt' was compiled with an incompatible version of Kotlin.
The binary version of its metadata is 1.9.0, expected version is 1.7.1.
The class is loaded from /nix/store/3a228ppiiljfvsrxyq15h25chmiwsmbh-gradle-8.4/lib/gradle/lib/
kotlin-stdlib-1.9.10.jar!/kotlin/collections/ArraysKt___ArraysKt.class
```

needed for #18321

In this commit we set `kotlinPluginVersion` to `1.9.0` and update `gradle` dependencies.

#### Platforms
- Android
  • Loading branch information
siddarthkay committed Jan 16, 2024
1 parent 455a739 commit 3f1057b
Show file tree
Hide file tree
Showing 5 changed files with 693 additions and 67 deletions.
2 changes: 1 addition & 1 deletion android/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ buildToolsVersion=33.0.0
supportLibVersion=28.0.0
# This should match version from nix/pkgs/aapt2/default.nix
gradlePluginVersion=7.4.2
kotlinPluginVersion=1.7.22
kotlinPluginVersion=1.9.0

android.useAndroidX=true
android.enableJetifier=true
Expand Down
Loading

0 comments on commit 3f1057b

Please sign in to comment.