Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci)_: skip windows build cleanup stage #6003

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

mendelskiv93
Copy link
Contributor

@mendelskiv93 mendelskiv93 commented Oct 28, 2024

Windows build pipeline has errors while running:

sh "rm -rf ${env.WORKSPACE}@tmp"

In cleanup stage:

process apparently never started in J:/Users/jenkins/workspace/_prs_windows_x86_64_main_PR-5990@tmp/durable-478fb71e
(running Jenkins temporarily with -Dorg.jenkinsci.plugins.durabletask.BourneShellScript.LAUNCH_DIAGNOSTICS=true might make the problem clearer)

Related with Durable Task Plugin.

Quick fix would be skipping this stage on Windows due to tmp folder being empty, as they should be at the end of the pipeline.
Opting only for

cleanup { cleanWs() }

as post cleanup step.

@mendelskiv93 mendelskiv93 requested a review from a team October 28, 2024 20:06
@status-im-auto
Copy link
Member

status-im-auto commented Oct 28, 2024

Jenkins Builds

Click to see older builds (39)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 25020e0 #1 2024-10-28 20:12:02 ~5 min linux 📦zip
✔️ 25020e0 #1 2024-10-28 20:12:05 ~5 min macos 📦zip
✔️ 25020e0 #1 2024-10-28 20:12:38 ~6 min tests-rpc 📄log
✔️ 25020e0 #1 2024-10-28 20:12:38 ~6 min android 📦aar
✔️ 25020e0 #1 2024-10-28 20:12:46 ~6 min windows 📦zip
✔️ 25020e0 #1 2024-10-28 20:14:51 ~8 min macos 📦zip
✔️ 25020e0 #1 2024-10-28 20:41:18 ~34 min tests 📄log
✔️ 5a568e2 #2 2024-10-29 10:14:38 ~4 min macos 📦zip
✔️ 5a568e2 #2 2024-10-29 10:14:58 ~5 min windows 📦zip
✔️ 5a568e2 #2 2024-10-29 10:16:18 ~6 min linux 📦zip
✔️ 5a568e2 #3 2024-10-29 10:16:18 ~6 min ios 📦zip
✔️ 5a568e2 #2 2024-10-29 10:16:50 ~7 min android 📦aar
✔️ 5a568e2 #2 2024-10-29 10:18:10 ~8 min macos 📦zip
✔️ 5a568e2 #2 2024-10-29 10:19:42 ~9 min tests-rpc 📄log
✔️ 5a568e2 #2 2024-10-29 10:48:35 ~38 min tests 📄log
✔️ 7c9a9ca #3 2024-10-29 11:55:09 ~4 min windows 📦zip
✔️ 7c9a9ca #3 2024-10-29 11:55:22 ~4 min macos 📦zip
✔️ 7c9a9ca #3 2024-10-29 11:55:23 ~4 min tests-rpc 📄log
✔️ 7c9a9ca #3 2024-10-29 11:55:48 ~4 min linux 📦zip
✔️ 7c9a9ca #3 2024-10-29 11:56:16 ~5 min macos 📦zip
✔️ 7c9a9ca #4 2024-10-29 11:56:29 ~5 min ios 📦zip
✔️ 7c9a9ca #3 2024-10-29 11:56:32 ~5 min android 📦aar
✖️ 7c9a9ca #3 2024-10-29 12:29:24 ~38 min tests 📄log
✔️ 5729d5b #4 2024-10-29 11:57:30 ~1 min tests-rpc 📄log
✔️ 5729d5b #4 2024-10-29 11:59:03 ~3 min windows 📦zip
✔️ 5729d5b #4 2024-10-29 11:59:52 ~4 min macos 📦zip
✔️ 5729d5b #4 2024-10-29 12:01:08 ~5 min linux 📦zip
✔️ 5729d5b #4 2024-10-29 12:01:42 ~5 min macos 📦zip
✔️ 5729d5b #4 2024-10-29 12:01:51 ~5 min android 📦aar
✔️ 5729d5b #5 2024-10-29 12:02:02 ~5 min ios 📦zip
✖️ 5729d5b #4 2024-10-29 13:13:45 ~44 min tests 📄log
✔️ 0a7e54b #5 2024-10-29 13:39:43 ~3 min windows 📦zip
✔️ 0a7e54b #5 2024-10-29 13:40:22 ~4 min macos 📦zip
✔️ 0a7e54b #5 2024-10-29 13:40:30 ~4 min tests-rpc 📄log
✔️ 0a7e54b #5 2024-10-29 13:41:04 ~5 min macos 📦zip
✔️ 0a7e54b #6 2024-10-29 13:41:32 ~5 min ios 📦zip
✔️ 0a7e54b #5 2024-10-29 13:41:39 ~5 min linux 📦zip
✔️ 0a7e54b #5 2024-10-29 13:42:21 ~6 min android 📦aar
✖️ 0a7e54b #5 2024-10-29 14:13:40 ~37 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 88cdbe0 #6 2024-10-29 16:56:28 ~2 min tests-rpc 📄log
✔️ 88cdbe0 #6 2024-10-29 16:58:31 ~3 min windows 📦zip
✔️ 88cdbe0 #6 2024-10-29 16:58:59 ~4 min macos 📦zip
✔️ 88cdbe0 #6 2024-10-29 16:59:47 ~5 min linux 📦zip
✔️ 88cdbe0 #6 2024-10-29 17:00:18 ~5 min android 📦aar
✔️ 88cdbe0 #6 2024-10-29 17:00:27 ~5 min macos 📦zip
✔️ 88cdbe0 #7 2024-10-29 17:01:32 ~7 min ios 📦zip
✔️ 88cdbe0 #6 2024-10-29 17:27:36 ~33 min tests 📄log
✔️ c08e922 #7 2024-10-30 11:00:08 ~2 min tests-rpc 📄log
✔️ c08e922 #7 2024-10-30 11:01:55 ~3 min windows 📦zip
✔️ c08e922 #7 2024-10-30 11:03:13 ~5 min linux 📦zip
✔️ c08e922 #7 2024-10-30 11:03:18 ~5 min macos 📦zip
✔️ c08e922 #7 2024-10-30 11:03:29 ~5 min android 📦aar
✔️ c08e922 #7 2024-10-30 11:03:39 ~5 min macos 📦zip
✔️ c08e922 #8 2024-10-30 11:05:26 ~7 min ios 📦zip
✔️ c08e922 #7 2024-10-30 11:30:40 ~32 min tests 📄log

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.62%. Comparing base (768cda8) to head (c08e922).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6003      +/-   ##
===========================================
+ Coverage    60.57%   60.62%   +0.04%     
===========================================
  Files          812      812              
  Lines       109328   109328              
===========================================
+ Hits         66230    66275      +45     
+ Misses       35337    35295      -42     
+ Partials      7761     7758       -3     
Flag Coverage Δ
functional 13.09% <ø> (-0.01%) ⬇️
unit 59.97% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 34 files with indirect coverage changes

Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you actually trying using LAUNCH_DIAGNOSTICS=true as the error suggests?

_assets/ci/Jenkinsfile.desktop Outdated Show resolved Hide resolved
@jakubgs
Copy link
Member

jakubgs commented Oct 29, 2024

It appears the Durable Task plugin cannot be installed because it is required by Docker plugin:

image

@jakubgs jakubgs force-pushed the ci/windows_cleanup branch 4 times, most recently from 0a7e54b to 88cdbe0 Compare October 29, 2024 16:54
@markoburcul markoburcul self-requested a review October 30, 2024 08:53
Windows build pipeline has errors while running:
```sh
sh "rm -rf ${env.WORKSPACE}@tmp"
```
In cleanup stage:
```groovy
process apparently never started in J:/Users/jenkins/workspace/_prs_windows_x86_64_main_PR-5990@tmp/durable-478fb71e
(running Jenkins temporarily with -Dorg.jenkinsci.plugins.durabletask.BourneShellScript.LAUNCH_DIAGNOSTICS=true might make the problem clearer)
```
Related with [Durable Task Plugin](https://plugins.jenkins.io/durable-task/).

Signed-off-by: Jakub Sokołowski <[email protected]>
@jakubgs jakubgs force-pushed the ci/windows_cleanup branch from 88cdbe0 to c08e922 Compare October 30, 2024 10:57
@jakubgs jakubgs merged commit c08e922 into develop Oct 30, 2024
20 checks passed
@jakubgs jakubgs deleted the ci/windows_cleanup branch October 30, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants