feat(telemetry)_: track total bandwidth #5973
Open
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (13)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5973 +/- ##
============================================
- Coverage 47.62% 10.60% -37.03%
============================================
Files 843 834 -9
Lines 138244 136994 -1250
============================================
- Hits 65845 14523 -51322
- Misses 64627 120617 +55990
+ Partials 7772 1854 -5918
Flags with carried forward coverage won't be shown. Click here to find out more.
|
adklempner
force-pushed
the
feat/telemetry-total-bandwidth
branch
2 times, most recently
from
90e7224 to
cb426a7
Compare
adklempner
force-pushed
the
feat/telemetry-total-bandwidth
branch
from
cb426a7 to
8f3957b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include total bandwidth in addition to bandwidth per protocol when pushing telemetry.
If telemetry is enabled, the node periodically sends the bandwidth as tracked by go-libp2p to the telemetry service. Currently, it sends the bandwidth as determined by which protocol was used. This adds an additional metric which tracks the total bandwidth as measured by libp2p.
Important changes:
Closes status-im/telemetry#62