Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore_: increase the mvds resend interval to save bandwidth. #5929

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

kaichaosun
Copy link
Contributor

MVDS resend the messages that is not acknowledges with exponential backoff. To further improve the bandwidth usage, increase the interval from 30 to 60.

@status-im-auto
Copy link
Member

status-im-auto commented Oct 8, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5da70f6 #1 2024-10-08 07:10:35 ~4 min tests-rpc 📄log
✔️ 5da70f6 #1 2024-10-08 07:11:00 ~4 min linux 📦zip
✔️ 5da70f6 #1 2024-10-08 07:11:34 ~5 min ios 📦zip
✔️ 5da70f6 #1 2024-10-08 07:12:07 ~5 min android 📦aar
✔️ 5da70f6 #1 2024-10-08 07:40:09 ~33 min tests 📄log
✔️ 8df7eff #1 2024-11-26 09:09:40 ~4 min macos 📦zip
✔️ 8df7eff #2 2024-11-26 09:09:55 ~4 min ios 📦zip
✔️ 8df7eff #2 2024-11-26 09:10:33 ~5 min linux 📦zip
✔️ 8df7eff #1 2024-11-26 09:10:36 ~5 min windows 📦zip
✔️ 8df7eff #2 2024-11-26 09:10:49 ~5 min tests-rpc 📄log
✔️ 8df7eff #2 2024-11-26 09:11:26 ~6 min android 📦aar
✔️ 8df7eff #1 2024-11-26 09:12:29 ~7 min macos 📦zip
✔️ 8df7eff #2 2024-11-26 09:36:20 ~31 min tests 📄log

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.99%. Comparing base (3466ac2) to head (8df7eff).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5929      +/-   ##
===========================================
+ Coverage    60.95%   60.99%   +0.04%     
===========================================
  Files          826      826              
  Lines       109631   109631              
===========================================
+ Hits         66824    66873      +49     
+ Misses       34965    34926      -39     
+ Partials      7842     7832      -10     
Flag Coverage Δ
functional 14.14% <ø> (+0.01%) ⬆️
unit 60.00% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol/datasync/transport.go 90.00% <ø> (ø)

... and 31 files with indirect coverage changes

@osmaczko osmaczko merged commit 2bd543b into develop Nov 28, 2024
20 checks passed
@osmaczko osmaczko deleted the tuning-mvds-backoff branch November 28, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants