Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump go-libp2p, go-waku and golang #4601

Closed
wants to merge 2 commits into from
Closed

chore: bump go-libp2p, go-waku and golang #4601

wants to merge 2 commits into from

Conversation

siddarthkay
Copy link
Contributor

@siddarthkay siddarthkay commented Jan 19, 2024 •
edited
Loading

This PR attempts to bump

  • libp2p
  • gowaku
  • golang

uses the same code which was reverted in : #4522

status-mobile PR to test : status-im/status-mobile#18564

status: ready

@siddarthkay siddarthkay self-assigned this Jan 19, 2024
@ghost
Copy link

ghost commented Jan 19, 2024

vendor/github.com/pion/webrtc/v3/yarn.lock changed. Pinging @corpetty

@status-im-auto
Copy link
Member

status-im-auto commented Jan 19, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (42)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4fbf861 #1 2024-01-19 16:51:30 ~3 min android 📦aar
✔️ 4fbf861 #1 2024-01-19 16:52:07 ~3 min linux 📦zip
✔️ 4fbf861 #1 2024-01-19 16:52:27 ~4 min ios 📦zip
✖️ 4fbf861 #1 2024-01-19 17:23:39 ~35 min tests 📄log
✔️ cc55e75 #3 2024-01-20 14:49:50 ~2 min android 📦aar
✔️ cc55e75 #3 2024-01-20 14:49:57 ~3 min linux 📦zip
✔️ cc55e75 #3 2024-01-20 14:50:14 ~3 min ios 📦zip
✔️ 9bf5df8 #4 2024-01-20 16:45:12 ~2 min ios 📦zip
✔️ 9bf5df8 #4 2024-01-20 16:45:35 ~3 min android 📦aar
✔️ 9bf5df8 #4 2024-01-20 16:45:42 ~3 min linux 📦zip
✔️ 5ffec68 #5 2024-01-22 14:14:16 ~1 min android 📦aar
✔️ 5ffec68 #5 2024-01-22 14:14:31 ~1 min linux 📦zip
✔️ 5ffec68 #5 2024-01-22 14:15:26 ~2 min ios 📦zip
✔️ 2db5b0b #6 2024-01-23 12:55:37 ~1 min android 📦aar
✔️ 2db5b0b #6 2024-01-23 12:55:42 ~1 min linux 📦zip
✔️ 2db5b0b #6 2024-01-23 12:57:36 ~3 min ios 📦zip
✔️ 5bedae1 #7 2024-01-23 13:05:48 ~1 min linux 📦zip
✔️ 5bedae1 #7 2024-01-23 13:07:19 ~2 min android 📦aar
✔️ 5bedae1 #7 2024-01-23 13:08:12 ~3 min ios 📦zip
✔️ 5bedae1 #7 2024-01-23 14:09:10 ~37 min tests 📄log
✔️ 0c79a22 #8 2024-01-25 05:57:51 ~1 min android 📦aar
✔️ 0c79a22 #8 2024-01-25 05:58:02 ~1 min linux 📦zip
✔️ 0c79a22 #8 2024-01-25 05:59:16 ~2 min ios 📦zip
✔️ 0c79a22 #8 2024-01-25 06:35:22 ~39 min tests 📄log
✔️ 3ba8010 #9 2024-01-26 12:23:49 ~1 min android 📦aar
✔️ 3ba8010 #9 2024-01-26 12:23:59 ~1 min linux 📦zip
✔️ 3ba8010 #9 2024-01-26 12:25:17 ~3 min ios 📦zip
✔️ 3ba8010 #9 2024-01-26 12:58:09 ~35 min tests 📄log
✔️ 1c9ff57 #10 2024-02-12 05:44:04 ~3 min android 📦aar
✔️ 1c9ff57 #10 2024-02-12 05:44:43 ~3 min linux 📦zip
✔️ 1c9ff57 #10 2024-02-12 05:46:12 ~5 min ios 📦zip
✔️ 1c9ff57 #10 2024-02-12 06:17:54 ~37 min tests 📄log
❌ 1c1b9ea #11 2024-02-12 05:48:25 ~11 sec linux 📄log
❌ 1c1b9ea #11 2024-02-12 05:48:42 ~28 sec android 📄log
❌ 1c1b9ea #11 2024-02-12 05:49:09 ~55 sec ios 📄log
❌ 9ea9000 #12 2024-02-12 06:07:24 ~16 sec linux 📄log
❌ 9ea9000 #12 2024-02-12 06:07:25 ~21 sec android 📄log
❌ 9ea9000 #12 2024-02-12 06:07:32 ~22 sec ios 📄log
❌ 0947a22 #13 2024-02-12 06:16:19 ~16 sec linux 📄log
❌ 0947a22 #13 2024-02-12 06:16:20 ~20 sec android 📄log
❌ 0947a22 #13 2024-02-12 06:16:27 ~22 sec ios 📄log
✖️ 0947a22 #11 2024-02-12 06:20:25 ~2 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ f3b1cb7 #14 2024-02-12 06:22:25 ~11 sec linux 📄log
❌ f3b1cb7 #14 2024-02-12 06:22:32 ~21 sec android 📄log
❌ f3b1cb7 #14 2024-02-12 06:22:37 ~21 sec ios 📄log
✖️ f3b1cb7 #12 2024-02-12 06:22:45 ~32 sec tests 📄log
❌ c4225f6 #15 2024-02-12 06:43:29 ~14 sec linux 📄log
❌ c4225f6 #15 2024-02-12 06:43:36 ~21 sec ios 📄log
✖️ c4225f6 #13 2024-02-12 06:44:14 ~55 sec tests 📄log
❌ c4225f6 #15 2024-02-12 06:45:00 ~1 min android 📄log

@ghost
Copy link

ghost commented Jan 19, 2024

vendor/github.com/pion/webrtc/v3/yarn.lock changed. Pinging @corpetty

@siddarthkay siddarthkay mentioned this pull request Jan 19, 2024
Closed
@ghost
Copy link

ghost commented Jan 20, 2024

vendor/github.com/pion/webrtc/v3/yarn.lock changed. Pinging @corpetty

@siddarthkay siddarthkay requested a review from cammellos January 20, 2024 14:12
@siddarthkay
Copy link
Contributor Author

@richard-ramos @cammellos : issue is fixed on status-mobile side, I'll run E2E and have QA look at this next week and then after that lets merge this.

@ghost
Copy link

ghost commented Jan 20, 2024

vendor/github.com/pion/webrtc/v3/yarn.lock changed. Pinging @corpetty

@siddarthkay siddarthkay force-pushed the bump-go-waku-and-golang branch from e344471 to cc55e75 Compare January 20, 2024 14:46
@ghost
Copy link

ghost commented Jan 20, 2024

vendor/github.com/pion/webrtc/v3/yarn.lock changed. Pinging @corpetty

1 similar comment
@ghost
Copy link

ghost commented Jan 20, 2024

vendor/github.com/pion/webrtc/v3/yarn.lock changed. Pinging @corpetty

@siddarthkay siddarthkay force-pushed the bump-go-waku-and-golang branch from 9bf5df8 to 5ffec68 Compare January 22, 2024 14:12
@ghost
Copy link

ghost commented Jan 22, 2024

vendor/github.com/pion/webrtc/v3/yarn.lock changed. Pinging @corpetty

@siddarthkay siddarthkay force-pushed the bump-go-waku-and-golang branch from 5ffec68 to 2db5b0b Compare January 23, 2024 12:53
@ghost
Copy link

ghost commented Jan 23, 2024

vendor/github.com/pion/webrtc/v3/yarn.lock changed. Pinging @corpetty

1 similar comment
@ghost
Copy link

ghost commented Jan 23, 2024

vendor/github.com/pion/webrtc/v3/yarn.lock changed. Pinging @corpetty

@richard-ramos richard-ramos mentioned this pull request Jan 24, 2024
Closed
@siddarthkay siddarthkay force-pushed the bump-go-waku-and-golang branch from 5bedae1 to 0c79a22 Compare January 25, 2024 05:56
@ghost
Copy link

ghost commented Jan 25, 2024

vendor/github.com/pion/webrtc/v3/yarn.lock changed. Pinging @corpetty

@siddarthkay siddarthkay force-pushed the bump-go-waku-and-golang branch from 0c79a22 to 3ba8010 Compare January 26, 2024 12:21
@ghost
Copy link

ghost commented Jan 26, 2024

vendor/github.com/pion/webrtc/v3/yarn.lock changed. Pinging @corpetty

@richard-ramos
Copy link
Member

Can we merge this?

@siddarthkay
Copy link
Contributor Author

Hi @richard-ramos : it was discussed recently that this and its corresponding status-mobile PR can be merged in a week after the current release testing is done
cc @status-im/mobile-qa

@pavloburykh
Copy link

Can we merge this?

Hi @richard-ramos! How critical it would be to merge this PR after cutting release go branch? We would prefer not to risk before release. I guess we will need another week before release branch is cut.

@richard-ramos
Copy link
Member

It's not critical. Let's wait after release. We can still use the older go version with no problems.

@siddarthkay siddarthkay force-pushed the bump-go-waku-and-golang branch from 3ba8010 to 1c9ff57 Compare February 12, 2024 05:40
@ghost
Copy link

ghost commented Feb 12, 2024

vendor/github.com/pion/webrtc/v3/yarn.lock changed. Pinging @corpetty

@siddarthkay siddarthkay force-pushed the bump-go-waku-and-golang branch from 1c9ff57 to 1c1b9ea Compare February 12, 2024 05:47
@ghost
Copy link

ghost commented Feb 12, 2024

vendor/github.com/pion/webrtc/v3/yarn.lock changed. Pinging @corpetty

2 similar comments
@ghost
Copy link

ghost commented Feb 12, 2024

vendor/github.com/pion/webrtc/v3/yarn.lock changed. Pinging @corpetty

@ghost
Copy link

ghost commented Feb 12, 2024

vendor/github.com/pion/webrtc/v3/yarn.lock changed. Pinging @corpetty

@siddarthkay siddarthkay force-pushed the bump-go-waku-and-golang branch from 0947a22 to f3b1cb7 Compare February 12, 2024 06:21
@ghost
Copy link

ghost commented Feb 12, 2024

vendor/github.com/pion/webrtc/v3/yarn.lock changed. Pinging @corpetty

@ghost
Copy link

ghost commented Feb 12, 2024

vendor/github.com/pion/webrtc/v3/yarn.lock changed. Pinging @corpetty

@caybro caybro mentioned this pull request Apr 2, 2024
Closed
@siddarthkay
Copy link
Contributor Author

closing in favour of : #5027

@siddarthkay siddarthkay closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-ramos richard-ramos richard-ramos approved these changes

@cammellos cammellos Awaiting requested review from cammellos

Assignees

@siddarthkay siddarthkay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siddarthkay @status-im-auto @richard-ramos @pavloburykh