Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve requesting contact/community info from mailserver #4110

Merged
merged 1 commit into from
Oct 6, 2023
Merged

chore: improve requesting contact/community info from mailserver #4110

merged 1 commit into from
Oct 6, 2023

Conversation

igor-sirotin
Copy link
Collaborator

  1. Use defer to forget requests
  2. Return error in case of timeout
  3. Minor refactoring

@igor-sirotin igor-sirotin requested a review from cammellos October 5, 2023 15:02
@igor-sirotin igor-sirotin self-assigned this Oct 5, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Oct 5, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 63c2996 #1 2023-10-05 15:06:54 ~3 min linux 📦zip
✔️ 63c2996 #1 2023-10-05 15:07:45 ~4 min ios 📦zip
✔️ 63c2996 #1 2023-10-05 15:08:44 ~5 min android 📦aar
✖️ 63c2996 #1 2023-10-05 15:34:10 ~30 min tests 📄log
✖️ 63c2996 #2 2023-10-05 15:46:57 ~4 min tests 📄log
✖️ 63c2996 #3 2023-10-06 12:25:55 ~28 min tests 📄log
✖️ 63c2996 #5 2023-10-06 14:21:40 ~28 min tests 📄log
✖️ 63c2996 #6 2023-10-06 15:07:00 ~28 min tests 📄log
✖️ 63c2996 #7 2023-10-06 15:40:08 ~28 min tests 📄log
✔️ 63c2996 #8 2023-10-06 16:13:11 ~28 min tests 📄log

This was referenced Oct 5, 2023
Merged
Merged
@igor-sirotin igor-sirotin requested a review from osmaczko October 5, 2023 16:16
@igor-sirotin igor-sirotin mentioned this pull request Oct 6, 2023
Merged
@igor-sirotin
Copy link
Collaborator Author

finally test passed 😅

@igor-sirotin igor-sirotin merged commit da3df63 into develop Oct 6, 2023
@igor-sirotin igor-sirotin deleted the chore/request-from-mailserver branch October 6, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrainville jrainville jrainville approved these changes

@cammellos cammellos Awaiting requested review from cammellos

@osmaczko osmaczko Awaiting requested review from osmaczko

Assignees

@igor-sirotin igor-sirotin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igor-sirotin @status-im-auto @jrainville