Prevent from completing tx multiple times #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
influx6
approved these changes
Sep 15, 2017
divan
reviewed
Sep 16, 2017
geth/node/txqueue.go
Outdated
| ErrQueuedTxIDNotFound = errors.New("transaction hash not found") | ||
| ErrQueuedTxTimedOut = errors.New("transaction sending timed out") | ||
| ErrQueuedTxDiscarded = errors.New("transaction has been discarded") | ||
| ErrQueuedTxInProgress = errors.New("transaction has started being processed already") |
There was a problem hiding this comment.
Maybe just "transaction is in progress"? "has started being processed already" seems a bit overcomplicated :)
divan
reviewed
Sep 16, 2017
geth/node/txqueue_manager.go
Outdated
| @@ -188,6 +193,7 @@ func (m *TxQueueManager) completeLocalTransaction(queuedTx *common.QueuedTx, pas | |||
| log.Info("complete transaction using local node", "id", queuedTx.ID) | |||
|
|
|||
| les, err := m.nodeManager.LightEthereumService() | |||
| log.Info("retrival les service", "err", err) | |||
tiabc
approved these changes
Sep 17, 2017
|
Transaction queue refactor issue #338. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents from completing (i.e. sending) the same transaction multiple times.
I successfully reproduced the bug described in #263 with a unit test. The problem was a missing guard which could prevent from using the same transaction in multiple
CompleteTransactioncalls.This is a quick solution but a well-though refactoring of
TxQueueManagerandTxQueueis required. I will follow up with a separate issue regarding that.