fix(wallet): in app tx related notifications improvements #16732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (35)
|
saledjenic
force-pushed
the
fix/issue-16338
branch
from
7140558 to
504236a
Compare
saledjenic
force-pushed
the
fix/issue-16338
branch
3 times, most recently
from
bf5fafc to
1dd9733
Compare
saledjenic
requested review from
a team,
micieslak,
caybro and
alexjba
as code owners
saledjenic
requested review from
Cuteivist,
alaibe and
Khushboo-dev-cpp
and removed request for
a team
alaibe
approved these changes
Nov 20, 2024
caybro
reviewed
Nov 20, 2024
ui/app/mainui/AppMain.qml
Outdated
| let toastType = Constants.ephemeralNotificationType.normal | ||
| let toastLink = "" | ||
|
|
||
| const sender = !!fromName? fromName : SQUtils.Utils.elideText(fromAddr, 6, 4) |
There was a problem hiding this comment.
Better use Utils.elideAndFormatWalletAddress()?
ui/app/mainui/AppMain.qml
Outdated
| toastType = Constants.ephemeralNotificationType.danger | ||
| icon = "warning" | ||
| case Constants.txStatus.failed: { | ||
| toastTitle = "Send failed: %1 from %2 to %3" |
ui/app/mainui/AppMain.qml
Outdated
| break | ||
| } | ||
| case Constants.SendType.Swap: { | ||
| toastTitle = qsTr("Swapp failed: %1 to %2 in %3").arg(sentAmount).arg(receivedAmount).arg(sender) |
There was a problem hiding this comment.
Suggested change
| toastTitle = qsTr("Swapp failed: %1 to %2 in %3").arg(sentAmount).arg(receivedAmount).arg(sender) | |
| toastTitle = qsTr("Swap failed: %1 to %2 in %3").arg(sentAmount).arg(receivedAmount).arg(sender) |
saledjenic
force-pushed
the
fix/issue-16338
branch
from
1dd9733 to
0d43683
Compare
… instead the default one only
saledjenic
force-pushed
the
fix/issue-16338
branch
from
0d43683 to
c40aa1d
Compare
|
@caybro comments addressed. Thanks. |
virginiabalducci
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
These user stories were tested and passed. The failed status was not tested yet.
Failed status will be tested later on a master build or a specific build where we can emulate tx errors to show the fail
SP-431: notifications for sent asset (erc20 + ETH) to non-saved address
SP-432: notifications for sent asset (erc20 + ETH) to saved address or own address
SP-434: notifications for bridge
SP-435: notifications for swap
SP-436: notifications for spending cap and swap
These missing items will be handled in a different issue #16810
- notifications for WC/BC
- notifications for Community minting and airdropping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding
status-goPR:Closes #16338