fix(@wallet/desktop): No feedback after token approval. Once the approval is confirmed the Swap dialog becomes editable again, with the Swap button enabled #16666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khushboo-dev-cpp
requested review from
a team,
micieslak,
caybro and
alexjba
as code owners
Khushboo-dev-cpp
requested review from
Cuteivist
and removed request for
a team
Jenkins BuildsClick to see older builds (16)
|
Khushboo-dev-cpp
force-pushed
the
fix/Release16569
branch
from
3874ec8 to
c8b8eb8
Compare
alexjba
approved these changes
Oct 30, 2024
|
Agreed with @Khushboo-dev-cpp that since we are working on fixing ephemeral notifications in the desktop app, globally, these changes should go only to the release branch, and not land on the master branch. |
Khushboo-dev-cpp
force-pushed
the
fix/Release16569
branch
from
c8b8eb8 to
2387fab
Compare
This was
linked to
issues
Oct 31, 2024
Why, we don't want them in master or next release(s)? |
|
@caybro because there is a bigger task that refactors and fixes all the toasts for the app , @saledjenic is on it. We will land it in 2.32 hopefully |
Khushboo-dev-cpp
force-pushed
the
fix/Release16569
branch
2 times, most recently
from
3467ae6 to
c83cce1
Compare
…oval is confirmed the Swap dialog becomes editable again, with the Swap button enabled fixes #16569
Khushboo-dev-cpp
force-pushed
the
fix/Release16569
branch
from
c83cce1 to
cb27537
Compare
|
Force merging with Nastya's blessing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16569, #16564
Go PR - status-im/status-go#5995
What does the PR do
his PR adds back missing Setting Spending Cap and Swapping... toasts with the correct token amounts.
The Spending cap set and Swapped... toasts are missing currently and perhaps should be addressed with new notifications design https://www.figma.com/design/FkFClTCYKf83RJWoifWgoX/Wallet-v2?node-id=25111-368170&node-type=instance&m=dev here.
Affected areas
Swap notifications
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Screen.Recording.2024-10-28.at.1.25.13.PM.mov