-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/deep link unfurl 16345 #16555
base: feat/deep-link-16345
Are you sure you want to change the base?
Feat/deep link unfurl 16345 #16555
Conversation
Jenkins Builds
|
aefe804
to
2000e11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM! 👍 Although some tests would be nice here. Maybe a simple smoke test for the squish E2E would be a good option? To test the URL generation, the presence of the preview card and opening the card.
Have you considered/tested mixing sender/receiver testnet flag?
E.g. Sender shares transaction url with testnet on. Receiver clicks the card with main net enabled (and vice versa).
That might be the the case. For example someone might send link to STT (testnet) tx, but other user might open it on mainnet. The result of that will be no asset selected. I will ask design on that case, as they might not be aware of that. |
Note: Already reviewed in #16541 (merge by mistake)
Task #16412
User stories: https://www.notion.so/Transaction-deep-link-10d8f96fb65c803c85fed5f4440ad439
Status-go : status-im/status-go#5958
What does the PR do
NOTE that this feature is behind feature flag. The design is not finished yet.
Affected areas
Chat
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
unfurling.mov
Impact on end user
What is the impact of these changes on the end user (before/after behaviour)
How to test
SET
FLAG_TRANSACTION_DEEP_LINK_ENABLED
env variable to 1 before running StatusSend / Bridge / Swap share button pasting
Risk
Described potential risks and worst case scenarios.
Tick one: