Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/deep link unfurl 16345 #16555

Draft
wants to merge 3 commits into
base: feat/deep-link-16345
Choose a base branch
from

Conversation

Cuteivist
Copy link
Contributor

Note: Already reviewed in #16541 (merge by mistake)

Task #16412

User stories: https://www.notion.so/Transaction-deep-link-10d8f96fb65c803c85fed5f4440ad439

Status-go : status-im/status-go#5958

What does the PR do

  • Added unfurling of transaction deep links
  • Added preview mini card for transaction preview (chat input)
  • Added chat preview card for transaction preview
  • Updated storybook

NOTE that this feature is behind feature flag. The design is not finished yet.

Affected areas

Chat

Architecture compliance

Screenshot of functionality (including design for comparison)

unfurling.mov

Impact on end user

What is the impact of these changes on the end user (before/after behaviour)

How to test

  • How should one proceed with testing this PR.

SET FLAG_TRANSACTION_DEEP_LINK_ENABLED env variable to 1 before running Status

  • What kind of user flows should be checked?

Send / Bridge / Swap share button pasting

Risk

Described potential risks and worst case scenarios.

Tick one:

  • Low risk: 2 devs MUST perform testing as specified above and attach their results as comments to this PR before merging.
  • High risk: QA team MUST perform additional testing in the specified affected areas before merging.

@Cuteivist Cuteivist requested review from micieslak, caybro, alexjba and a team as code owners October 21, 2024 10:32
@Cuteivist Cuteivist marked this pull request as draft October 21, 2024 10:32
@status-im-auto
Copy link
Member

status-im-auto commented Oct 21, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fa9984c #1 2024-10-21 10:39:28 ~6 min macos/aarch64 🍎dmg
✔️ fa9984c #1 2024-10-21 10:40:09 ~7 min tests/nim 📄log
✔️ fa9984c #1 2024-10-21 10:45:09 ~12 min tests/ui 📄log
✔️ fa9984c #1 2024-10-21 10:51:21 ~18 min linux-nix/x86_64 📦tgz
✔️ fa9984c #1 2024-10-21 10:52:31 ~19 min linux/x86_64 📦tgz
✔️ fa9984c #1 2024-10-21 10:52:38 ~19 min macos/x86_64 🍎dmg
✔️ fa9984c #1 2024-10-21 11:00:19 ~27 min windows/x86_64 💿exe

@Cuteivist Cuteivist force-pushed the feat/deep-link-16345 branch from aefe804 to 2000e11 Compare October 21, 2024 10:50
Copy link
Contributor

@alexjba alexjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM! 👍 Although some tests would be nice here. Maybe a simple smoke test for the squish E2E would be a good option? To test the URL generation, the presence of the preview card and opening the card.

Have you considered/tested mixing sender/receiver testnet flag?
E.g. Sender shares transaction url with testnet on. Receiver clicks the card with main net enabled (and vice versa).

@Cuteivist
Copy link
Contributor Author

The code LGTM! 👍 Although some tests would be nice here. Maybe a simple smoke test for the squish E2E would be a good option? To test the URL generation, the presence of the preview card and opening the card.

Have you considered/tested mixing sender/receiver testnet flag? E.g. Sender shares transaction url with testnet on. Receiver clicks the card with main net enabled (and vice versa).

That might be the the case. For example someone might send link to STT (testnet) tx, but other user might open it on mainnet. The result of that will be no asset selected.

I will ask design on that case, as they might not be aware of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants