Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display all required contact data in token holders list #11858

Closed
MishkaRogachev opened this issue Aug 10, 2023 · 1 comment · Fixed by #11923
Closed

Display all required contact data in token holders list #11858

MishkaRogachev opened this issue Aug 10, 2023 · 1 comment · Fixed by #11923
Labels
E:Desktop Tokenized Ownership Implementation of the tokenization of community ownership and transfer of said ownership feature

Comments

@MishkaRogachev
Copy link
Contributor

MishkaRogachev commented Aug 10, 2023

The token holder list in SortableTokenHoldersList.qml can display two types of entries:

  • Unknown token holder, who is not a community member. For such holders only wallet address is displayed.
  • Community member token holder.
Screenshot 2023-08-09 at 18 13 25

For second case we should add a contact details such as online status, ens, ringSpecModel and etc.

@MishkaRogachev
Copy link
Contributor Author

The way i see it is to reuse StatusSmartIdenticon and getContactDetailsAsJson:

    function updateContactDetails() {
        contactDetails = contactId !== "" ? Utils.getContactDetailsAsJson(contactId, false) : null
    }

    onContactIdChanged: root.updateContactDetails()

    Connections {
        target: root.store.contactsStore.myContactsModel

        function onItemChanged(pubKey) {
            if (pubKey === root.contactId)
                root.updateContactDetails()
        }
    }

@MishkaRogachev MishkaRogachev added E:Desktop Tokenized Ownership Implementation of the tokenization of community ownership and transfer of said ownership messenger-team labels Aug 10, 2023
@MishkaRogachev MishkaRogachev linked a pull request Aug 17, 2023 that will close this issue
5 tasks
MishkaRogachev added a commit that referenced this issue Aug 22, 2023
* feat(Communities): Refactor token holder list item to separate file

Close #11858

* feat(Communities): Use contact details for community member info

* feat(Communities): reuse StatusMemberListItem for member token holder

* Review fixes

Co-authored-by: Michał Iskierko <[email protected]>

---------

Co-authored-by: Michał Iskierko <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Status Desktop/Mobile Board Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:Desktop Tokenized Ownership Implementation of the tokenization of community ownership and transfer of said ownership feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant