use consensus spec v1.3.0-rc.3 test vectors #4645
Conversation
|
|
||
| # Extra payload fields | ||
| block_hash*: Eth2Digest # Hash of execution block | ||
| transactions*: List[Transaction, MAX_TRANSACTIONS_PER_PAYLOAD] | ||
| withdrawals*: List[Withdrawal, MAX_WITHDRAWALS_PER_PAYLOAD] | ||
| excess_data_gas*: UInt256 # [New in EIP-4844] |
There was a problem hiding this comment.
Also, deliberately didn't update the https://github.com/ethereum/consensus-specs/blob/v1.3.0-rc.2/specs/eip4844/beacon-chain.md#executionpayload etc URLs for these. So they mark it as not-yet-reviewed for actually being 100% consistent with rc.3, just enough to pass tests. So would not have updated them to rc.3 without changing that.
Deliberately didn't update the rest of the URLs either, even the easy ones. That was always going to be a separate PR, to keep the noisy/invasive changes also completely semantics-change-free, i.e. why all those PRs have descriptions along the lines of comments/markdown only. This makes enough changes I wanted people to be able to see what it did and not be buried in hundreds of lines of comment changes.
That's part of the purpose/value of these -- it's okay to make these partial updates, too. In this case, it's true that I'd have preferred to update the wording to Deneb at the same time since it's no more invasive once one is moving the line as a whole.
|
|
||
| # Extra payload fields | ||
| block_hash*: Eth2Digest # Hash of execution block | ||
| transactions_root*: Eth2Digest | ||
| withdrawals_root*: Eth2Digest | ||
| excess_data_gas*: UInt256 # [New in EIP-4844] |
https://github.com/ethereum/consensus-specs/releases/tag/v1.3.0-rc.3
https://github.com/ethereum/consensus-spec-tests/releases/tag/v1.3.0-rc.3
Mostly minimal changes included, though it doesn't implement ethereum/consensus-specs#3244 in any meaningful way, just adds the SSZ objects to pass the tests.