Reviewed the Engine API calls for missing error handling #4004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zah
force-pushed
the
more-engine-api-error-handling
branch
from
63eefd4 to
39cc47c
Compare
tersec
reviewed
Aug 19, 2022
| warn "Getting execution payload from Engine API timed out", payload_id | ||
| empty_execution_payload | ||
| except CatchableError as err: | ||
| warn "Getting execution payload from Engine API failed", |
There was a problem hiding this comment.
Why is one error and one warn?
There was a problem hiding this comment.
My reasoning was that we have a recovery path in this case (the empty payload), but I agree that's quite debatable.
tersec
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.