Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐼 #3670

Merged
merged 3 commits into from
May 30, 2022
Merged

🐼 #3670

merged 3 commits into from
May 30, 2022

Conversation

tersec
Copy link
Contributor

@tersec tersec commented May 28, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented May 28, 2022

Unit Test Results

     12 files  ±0     842 suites  ±0   52m 16s ⏱️ + 4m 52s
1 699 tests ±0  1 647 ✔️ ±0    52 💤 ±0  0 ±0 
9 893 runs  ±0  9 765 ✔️ ±0  128 💤 ±0  0 ±0 

Results for commit 3b3f417. ± Comparison against base commit bf1763f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@etan-status etan-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐼

beacon_chain/consensus_object_pools/pandas/pandas.nim Outdated Show resolved Hide resolved
beacon_chain/consensus_object_pools/block_pools_types.nim Outdated Show resolved Hide resolved
beacon_chain/consensus_object_pools/pandas/pandas.nim Outdated Show resolved Hide resolved
beacon_chain/consensus_object_pools/pandas/pandas.nim Outdated Show resolved Hide resolved
@@ -179,7 +181,8 @@ proc loadChainDag(
onLCFinalityUpdateCb = onLightClientFinalityUpdateCb,
onLCOptimisticUpdateCb = onLightClientOptimisticUpdateCb,
serveLightClientData = config.serveLightClientData.get,
importLightClientData = config.importLightClientData.get)
importLightClientData = config.importLightClientData.get,
pandaTexts = getPandas(detectTTY(config.logStdout)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If an additional cmd line argument needed in CI setups to force color output, e.g., when running through docker, will people streaming nimbus terminals need to know about it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, currently, the only ways to see the color ones are to either use --log-format=colors or --log-format=auto (the default) on what Nimbus detects as a TTY.

Whether this works in/through Docker containers depends on the terminal emulation setup, if there's a TTY in Docker.

beacon_chain/consensus_object_pools/pandas/pandas.nim Outdated Show resolved Hide resolved
beacon_chain/consensus_object_pools/pandas/pandas.nim Outdated Show resolved Hide resolved
QM$Mb .d$b. .d$b. .d$b. .d$b. $$$$$ $\ /$ $: $$ .d$b. $$$$$ $$$$$ $$$b. d$P
|: d$ $: $$ $b."P $: $$ $: "" [$: [$: Q$:$P $: $$ [$: $P.. $: Q$ .$$;
Pb"' $: $$ `""b. $$22$ $: mm [$: [$: Q$P $$$$$ [$: $b"" $: d$ `$:
|$b `Q$P' `MpM; $: $$ `Q$P' [$: $$$$$ `$' $: $$ [$: $$ETH $$$$' mm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐼

@tersec tersec enabled auto-merge (squash) May 30, 2022 07:54
@tersec tersec merged commit 01534b0 into unstable May 30, 2022
@tersec tersec deleted the tS7 branch May 30, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants