Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Eth1 distance runtime configurable #1453

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

protolambda
Copy link
Contributor

Not sure if I'm doing this right, but needed this for a new lighthouse/nimbus dev testnet. Will test it now for genesis and report back.

@protolambda
Copy link
Contributor Author

Genesis worked 🎉
Testnet details here: https://github.com/protolambda/fafafa

Need to fix the constant-number tests though, but not sure how that works in nim. Can someone help out here?

@zah
Copy link
Contributor

zah commented Aug 6, 2020

Thanks @protolambda, the patch is almost perfect. I've pushed only a small change that should fix the CI issues.

@protolambda protolambda marked this pull request as ready for review August 6, 2020 11:05
@protolambda
Copy link
Contributor Author

Thanks zah, appreciate it. But feel free to make any changes, I don't write nim enough to see what works best here, or how it should work in nimbus.

@zah zah merged commit 009e9a6 into status-im:devel Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants