Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ci.yml and be more explicit in .nimble #82

Merged
merged 1 commit into from
Jun 26, 2024
Merged

update ci.yml and be more explicit in .nimble #82

merged 1 commit into from
Jun 26, 2024

Conversation

narimiran
Copy link
Contributor

No description provided.

@tersec
Copy link
Contributor

tersec commented Jun 26, 2024

CI failures are not as a result of the PR

@tersec tersec merged commit 5f5e0f8 into master Jun 26, 2024
5 of 15 checks passed
@tersec tersec deleted the update-ci branch June 26, 2024 10:08
@tersec
Copy link
Contributor

tersec commented Jun 26, 2024

Basically ORC fails now, but refc works. This was true even with released v2.0.6 on master before merging. This is a known issue with nim-metrics to some extent, that it's not really gc-safe by design.

One option here is to just only test it in refc (or use our usual trick of, have it fail on success and vice versa in ORC) -- for IFT/Nimbus there's not really an ORC use case yet, and despite this particular PR not making it worse, it would be worth triaging what one cares about this CI to "work" (which is basically refc, ORC optional) and make sure that's prioritized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants