Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing_boiler macro to not need a nightly compiler #234

Merged
merged 5 commits into from
May 27, 2024

Conversation

FreezyLemon
Copy link
Contributor

Addresses part of #233.

This makes the macro a bit more complicated but removes the need for the fn_traits feature.

Instead of

testing_boiler!((f64, f64), Beta);

#[test]
fn some_test() {
    let arg = (1.0, 2.0);
    try_create(arg);
}

it's now

testing_boiler!(a: f64, b: f64; Beta);

#[test]
fn some_test() {
    let arg_a = 1.0;
    let arg_b = 2.0;
    try_create(arg_a, arg_b);
}

Also update dependent testing modules
- slice instead of `&Vec<_>`
- remove legacy constants
- allow number that is coincidentally close to E
- use `consts::FRAC_1_PI` instead of literal value
@YeungOnion
Copy link
Contributor

haha, same approach I took, playground
Thanks for this, that was quick.

@YeungOnion YeungOnion merged commit 12f7bf4 into statrs-dev:master May 27, 2024
5 checks passed
YeungOnion added a commit that referenced this pull request May 27, 2024
@FreezyLemon FreezyLemon deleted the remove-nightly-feature branch May 27, 2024 13:55
@YeungOnion YeungOnion linked an issue May 28, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change compile requirements for running cargo test
2 participants