Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and updates #134

Merged
merged 8 commits into from
Apr 19, 2021
Merged

Fixes and updates #134

merged 8 commits into from
Apr 19, 2021

Conversation

vks
Copy link
Contributor

@vks vks commented Apr 13, 2021

The tests and benchmarks on master are currently broken. They are fixed in this PR. Additionally, some warnings are fixed and the dependencies are updated.

Fixes #128.
Fixes #133.

vks added 7 commits April 12, 2021 20:30
There was a duplicate line (presumably a leftover from a merge) and a
duplicated test, resulting in compilation errors. Those have been fixed.
@troublescooter troublescooter self-assigned this Apr 17, 2021
@rob-p
Copy link

rob-p commented Apr 19, 2021

Is there any chance this will be merged soon? I'm looking to tag a release of something that depends on statrs, and I'd prefer to pull from the official crate if possible. However, if there are reasons that this won't be merged soon (or potentially) at all, then it is worth it to pull from the fork for the time being to avoid the rand 0.7 dependency creeping in. Thanks!

@troublescooter
Copy link
Collaborator

I currently don't have the permissions to make a release, if that's what you need, but I'll try and get in touch with the owner.
If a merge is what you need, I'll take care of it today after work.

This required introducing a new "nightly" feature.
@troublescooter
Copy link
Collaborator

Thanks!

@troublescooter troublescooter merged commit 8f08cda into statrs-dev:master Apr 19, 2021
@vks vks deleted the fixes-and-updates branch May 10, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to rand >= 0.8
3 participants