Fix 35/optimize personalization calculation #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #35.
![performance](https://user-images.githubusercontent.com/42291858/139032112-3e155751-e953-4697-a253-fe0fdc188047.png)
As the cosine similarity metric is symmetric, we don't need the upper triangle indices to calculate the mean of the matrix.
Just subtract the diagonal (all ones) and divide by the number of distances (without the diagonal).
This way the performance is increased and is noticeable on matrices over 50k x 50k.
All tests passed.
Performance before and after the modification (skipping make_rec_matrix):