Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yarn option #238

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

calebeby
Copy link

@calebeby calebeby commented May 13, 2017

See #234

@calebeby
Copy link
Author

Hm. The yarn install issue in the first build must have been a network issue.

@jescalan
Copy link
Member

I know this might be difficult, but it would be great to add a test for this. I think you'd have to make some small changes to the travis config file to get it installed properly.

@calebeby
Copy link
Author

I figured you'd ask for tests :)

So you want it to run spike new in the tests and check if node_modules exists?

@jescalan
Copy link
Member

You can just check if it compiles -- if node_modules doesnt exist, you know it's not working. There's already a test for the new command in there, you'd just have to add another with this flag 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants