fix(autoload): Colon after protocol (#65)

If protocol is explicitly specified, ensure a colon is added.
statianzo · Mar 8, 2021 · a876ff4 · a876ff4
1 parent 3e8e219
commit a876ff4
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -176,6 +176,8 @@ class LiveReloadPlugin {
    * @private
    */
   _autoloadJs() {
+    const protocol = this.options.protocol;
+    const fullProtocol = `${protocol}${protocol ? ':' : ''}`
     return (
         `
         // webpack-livereload-plugin
@@ -186,7 +188,7 @@ class LiveReloadPlugin {
           var el = document.createElement("script");
           el.id = id;
           el.async = true;
-          el.src = "${this.options.protocol}//${this.options.hostname}:${this.options.port}/livereload.js";
+          el.src = "${fullProtocol}//${this.options.hostname}:${this.options.port}/livereload.js";
           document.getElementsByTagName("head")[0].appendChild(el);
           console.log("[Live Reload] enabled");
         }());

diff --git a/test.js b/test.js
@@ -260,3 +260,19 @@ test('autoloadJs contains instanceId', function(t) {
   t.end();
 });
 
+test('autoloadJs suffixes protocol with colon', function(t) {
+  const plugin = new LiveReloadPlugin({
+    protocol: 'https'
+  });
+  const [,src] = plugin._autoloadJs().match(/src\s+=\s+"(.+)"/)
+  t.assert(src.startsWith('https://'));
+  t.end();
+});
+
+
+test('autoloadJs suffixes empty protocol without colon', function(t) {
+  const plugin = new LiveReloadPlugin();
+  const [,src] = plugin._autoloadJs().match(/src\s+=\s+"(.+)"/)
+  t.assert(src.startsWith('//'));
+  t.end();
+});