Serializer test fix #1875
Merged
Serializer test fix #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourishkrout
approved these changes
Dec 20, 2024
|
Ran the tests out-of-band and they all passed. The e2e tests suite requires Thank you, @hotpocket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cell outputs marshalingtest checks anitem.data.typeproperty which is not valid per the proto. This test works because the Notebook.clone() method inserializer.ts/marshalNotebook()stores this data which is later accessed in the test. During normal operation the NotebookData that marshalNotebook receives has aBufferobject foritem.datanot a{'type':'Buffer','data':[1,2,3,...]}type. A fix is provided here to make the fixture more representative of what would be encountered in normal operation of the extension.Side note: work I am doing to convert from timostamm-ts to protobuf_es creates a Notebook differently, which strips out this invalid structure/data, which is how this bug was caught. I believe this fix will allow the two to coexist. The other PR for the conversion is almost ready...