Refactor StatefulAuthProvider for static initialization and improved session management #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/extension/extension.ts
Outdated
| @@ -490,6 +490,14 @@ export class RunmeExtension { | |||
|
|
|||
| if (kernel.isFeatureOn(FeatureName.RequireStatefulAuth)) { | |||
| await StatefulAuthProvider.instance.ensureSession() | |||
| StatefulAuthProvider.instance.currentSession().then(async (session) => { | |||
There was a problem hiding this comment.
@pastuxso don't we need to await this here?
There was a problem hiding this comment.
Good catch! I realized we really needed to await this, as not doing so could lead to race conditions or unexpected behavior. To address this, I refactored the ensureSession function to properly return the session and updated the flow to await it where necessary.
There was a problem hiding this comment.
Let me know if you have further suggestions!
|
Let's break it in as a pre-release version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor centralizes session management, reduces duplication, and improves maintainability across the extension.