-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves user experience inside Stateful Cloud Playgrounds #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastuxso
force-pushed
the
cris/playgrounds-changes
branch
from
November 9, 2024 02:13
8a79565
to
aa2f793
Compare
pastuxso
changed the title
Adds playgrounds features
Improves user experience inside Stateful Cloud Playgrounds
Nov 9, 2024
sourishkrout
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pastuxso can we move these two UX features into one that is isHostedPlayground
or something like that please?
pastuxso
force-pushed
the
cris/playgrounds-changes
branch
from
November 12, 2024 00:14
38824b2
to
3c9bb49
Compare
Merged AutoOpenTerminal and AddTrustedDomains into a single feature flag: HostedPlayground, per code review feedback.
sourishkrout
force-pushed
the
cris/playgrounds-changes
branch
from
November 13, 2024 01:40
3c9bb49
to
b956514
Compare
sourishkrout
force-pushed
the
cris/playgrounds-changes
branch
from
November 13, 2024 01:42
b956514
to
73b695e
Compare
sourishkrout
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces changes to enhance the user experience when running hosted extension within Stateful Cloud Playgrounds.