Add typechain to nitro-protocol #3604
Conversation
| export let erc20AssetHolder: Contract; | ||
| export let nitroAdjudicator: Contract; | ||
| export let token: Contract; | ||
| export let ethAssetHolder: ETHAssetHolder & Contract; |
There was a problem hiding this comment.
I don't think this intersection type is the canonical way to use typechain. But it works well!
| @@ -112,6 +112,7 @@ jobs: | |||
| - packages/*/dist | |||
| - packages/*/build | |||
| - packages/nitro-protocol/artifacts | |||
| - packages/nitro-protocol/typechain | |||
There was a problem hiding this comment.
Clarifying circle config:
This is writing these directories into the filesystem of circleCI's vm, and not persisting in the 'artifact' sense? It writes these to make them available for the later test job.
There was a problem hiding this comment.
This is great! The gas benchmarks, along with typechain, serve as a much improved walk-through of nitro workflows with great discoverability.
I am having had some trouble running this locally. For reference, things were cleared up after some yarn clean, yarn, and closing out all VSCode windows, which seemed to be hanging onto some out of date cached typings.
https://www.notion.so/statechannels/Add-TypeChain-tooling-f17342226cb44244be4820b9937c9fae
This PR brings us to a state where we can do this:
I didn't spread the types around the codebase much, yet. For now I just used them in the gas benchmarking test. We can do more of that kind of thing in future PRs.