CRAN problem fixes #142
Merged
CRAN problem fixes #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…repeated code into 2 small helper functions: separationDetection and separationWarning
|
#141 apparently related issue, just spotted this now |
|
@david-barnett Thank you so much for this wonderful pull request! Just reviewed it and will be merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @bryandmartin
Thanks for the great package. This pull request attempts to fix the problems that appear to have caused corncob's removal from CRAN.
The main problem appears to be caused by the cran release of detectseparation version 0.3 which changes the name of one of the elements in the list returned by detect_separation.
I ran devtools::check on my machine, and addressed another couple of warnings and notes too, in separate commits.
Hope this helps to get corncob back on cran 🙂
cheers,
David