Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix issues with Please commands on Laravel 11 #9877

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented Apr 12, 2024

This pull request fixes two issues with Please commands on Laravel 11:

  • It fixes an issue where an app's commands in app/Console/Commands with the RunsInPlease alias weren't available with Please. Updating getArtisan to be inline with Laravel's method fixes that.
  • It fixes an issue where Artisan commands couldn't be called using Artisan::call(). We "defer" regular non-please commands within please so they don't show up in the listing. We fix this by resolving them when using Artisan::call().

Closes #9875.
Closes #9861.

@robdekort
Copy link
Contributor

Also amazing!

@jasonvarga jasonvarga merged commit d645e80 into master Apr 12, 2024
33 checks passed
@jasonvarga jasonvarga deleted the fix/please-command-issues branch April 12, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants