-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Simplify TestCase
for addons
#9573
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
added a commit
to statamic-rad-pack/runway
that referenced
this pull request
Feb 24, 2024
Made possible because of statamic/cms#9573.
This was referenced Feb 24, 2024
This was referenced Apr 4, 2024
duncanmcclean
added a commit
to statamic-rad-pack/runway
that referenced
this pull request
Apr 9, 2024
* Change how we call the Antlers parser * Simplify the `TestCase` Made possible because of statamic/cms#9573. * Tweak version in `composer.json` * tweak version in testing matrix too * Update orchestra/testbench * update system requirements in docs * Casts are now defined in a method * Add notes about dropped support to upgrade guide * Replace `str_slug` with `Str::slug` * Improve UX of commands * Fix failing tests after improving console UX * Adopt new `casts` method * Use the real 5.0 version constraint * Tweak Orchestra Testbench versions & drop test script from `composer.json` * whoopsie, fix invalid json
This was referenced Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
AddonTestCase
class which can be used by addon developers to simplify their addon'sTestCase
.Currently, addons need to implement a bunch of methods to boot Statamic, boot your addon's service providers & setup the addon's manifest.
Now, with the changes in this PR, the
TestCase
for most addons can be simplified to:To Do
AddonServiceProvider
also get automatically loaded in tests.