[4.x] PHPUnit 10 #9529
Merged
[4.x] PHPUnit 10 #9529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/Fieldtypes/ReplicatorTest.php
…ingEqualsStringIgnoringLineEndings where needed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the test suite to use PHPUnit 10. (PHPUnit 9 is still used for older versions)
It's required for the upgrade to Laravel 11. Having this in a separate PR will make #9434 easier to review as it will just be Laravel 11 related changes, and not a ton of test files.
staticto data providersProvidersuffix to data provider methods for consistencyTestwhich PHPUnit 10 doesn't like.resultmethod which now exists in PHPUnit 10.assertEquals. You can't override it anymore because it's nowfinal. We use theassertStringEqualsStringIgnoringLineEndingsto get the same behavior. Copied the PHPUnit 10 thing locally to get the same effect on PHPUnit 9.