Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Filters refinements #8001

Merged
merged 36 commits into from
Apr 27, 2023
Merged

[4.x] Filters refinements #8001

merged 36 commits into from
Apr 27, 2023

Conversation

jesseleite
Copy link
Member

@jesseleite jesseleite commented Apr 25, 2023

  • Make filters bar always visible to remove the extra click to access.
  • Bring back pinned filters concept to keep UX minimal and clean, with or without lots of custom filters.
  • Pin all core filters by default for easier access.
  • Add Duplicate view/preset option.
  • Add Rename view/preset option.
  • Fix + button view/preset behaviour.
  • Apply all the above changes to:
    • Entries listing
    • Terms listing
    • Form submissions listing
    • Users listing
    • User group users listing

Fixes #7807

@what-the-diff
Copy link

what-the-diff bot commented Apr 25, 2023

PR Summary

  • Improved filter badge styling
    Changed the styling of filter badges for better appearance
  • Added preset management in dropdown menu
    Users can now duplicate or delete presets directly from a dropdown menu without opening the modal window
  • Resolved spacing issues
    Fixed some spacing issues with filters and field selectors in data lists (e.g., on /admin/users)
  • Removed alwaysShowFilters config option
    Eliminated an unnecessary configuration option
  • Implemented pinned property in Filter class
    Optimized filter visibility by using the pinned property, showing filters by default (pinned = true) or hidden until clicked on (pinned = false)
  • Updated filter classes
    Improved filter classes extending from Statamic\Query\Scopes\Filter to have their own $pinned properties set correctly
  • New property in Status class
    Added a new property to the Status class for better maintenance
  • Visibility change in UserGroup and UserRole classes
    Changed the visibility of the pinned property in UserGroup and UserRole classes from protected to public for improved accessibility

@jesseleite jesseleite requested a review from jackmcdade April 25, 2023 23:13
@jasonvarga
Copy link
Member

jasonvarga commented Apr 26, 2023

When you are in the "All" preset, set something like a search query or filter, clicking the "Reset" button results in JS errors and doesn't reset anything.

@jesseleite jesseleite requested a review from jasonvarga April 27, 2023 19:59
@jesseleite jesseleite marked this pull request as ready for review April 27, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants