Optionally include unpublished entries

[arthurperton]

This PR applies the policy to exclude unpublished entries by default, and leave the option to include them by using a filter explicitly.

• fix Entries fieldtype: status filter to include unpublished entries #3918
• fix Entries columns in CP listing dont display unpublished entires #4251
• apply the same policy to Terms, as I mentioned in unpublished entries you get from taxonomies are not filtered out #7322

[arthurperton]

It all seems to work well now.

In StatusQueryBuilder@queriesStatus() you can see that reflection is used to drill down through the decorators and get the protected wheres property from the actual Builder. Again it all works well, but it is also a bit hacky.

It would be nice to access the wheres property by adding a getter to the abstract Builder class. The decorators would automatically forward the call to the Builder and no funky reflection is needed.

[arthurperton]

I decided to add the wheres() getter. Ready for review now.

[jasonvarga]

This looks good but I don't think it will work when using the eloquent driver, or any other entry driver.

They won't have a wheres method in it.

It might be tedious but I think we need to override all the where methods.

public function where($column, $operator = null, $value = null, $boolean = 'and')
{
    if ($column === 'status') {
       $this->hasQueriedStatus = true;
    }

    $this->builder->where($column, $operator, $value, $boolean);

    return $this;
}

public function whereIn($column, $values, $boolean = 'and') { ... }
public function orWhereIn($column, $values) { ... }

// etc

[what-the-diff]

• Fix relationship fieldtype to show unpublished entries
• Add StatusQueryBuilder for querying status in a more flexible way
• Use the new query builder on taxonomy terms and entry relationships (entries) fields, so that they can be filtered by any status or published state without breaking existing functionality

[arthurperton]

Thank you for that feedback. The where.. methods are being intercepted now to check if the status is queried.

[jasonvarga]

Nice solution.

[arthurperton]

Thank you. I see now that I actually forgot the basic where method, adding it now.

[stoffelio]

Any chance this will find its way into core with 4.0?

[jasonvarga]

Made some small tweaks and adjusted tests.

Also, I added the ability to pass in the $status to the StatusQueryBuilder. We don't actually use it, but I like keeping the class called StatusQueryBuilder. If we left the status hardcoded to published, it's really more of a PublishedQueryBuilder, which just sounds weird. 😂

[arthurperton]

😀 very nice! I am glad that this is integrated.