Fix revealer fields disappearing on save #7329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jacksleight With this PR / v3.3.65 we can't close revealers anymore - just a little flicker and its open again? EDIT: We use toggle mode |
jesseleite
added a commit
that referenced
this pull request
Jan 20, 2023
This reverts commit 1daa115.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7306
I assume this was caused by #6842, as after update the revealer field is no longer
trueso the conditional fields get hidden again.This PR fixes it by watching for a new
falsevalue and re-callingbuttonReveal()if the current value istrue. I suspect there might a better way to fix this within the publish container itself, rather than updating and the immediately reverting the value, but that's a bit beyond me.