Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel 9 compatibility #5188

Merged
merged 74 commits into from
Feb 21, 2022
Merged

Laravel 9 compatibility #5188

merged 74 commits into from
Feb 21, 2022

Conversation

jesseleite
Copy link
Member

@jesseleite jesseleite commented Feb 2, 2022 •
edited
Loading

  • Update necessary code and pass tests for Laravel 9.0
  • Add backwards compatible support for certain required dependency updates
    • league/flysystem 3.x
    • league/commonmark 2.x
    • league/glide 2.x
    • rebing/graphql-laravel 8.x

@jesseleite
Dependency hell (wip).
c785544
@jesseleite
Use new method of instantiating environment and converter with custom…
e3e6388 
… config.
@jesseleite
Cannot get config array from environment anymore, so return new objec…
a38251d 
…t instead.
@jesseleite
Ensure we merge with the original $config array.
c582d69
@jesseleite
The convertToHtml() method is deprecated, use new convert() method.
f8ee8ed
@jesseleite
Update custom parser extension examples to adhere to new interfaces.
7176751
@jesseleite
Update parser tests to use the new getters and valid config rules (ie…
d0ebaf0 
…. can't pass `foo` anymore).
@jesseleite
Make ParserTest pass for league/commonmark 1 and 2.
49391ef
@jesseleite
Actually, we can continue using CommonMarkConverter, as it has a `g…
f683f95 
…etEnvironment()` method 🎉
@jesseleite
Ensure Markdown\Manager returns correct parser for commonmark version.
d563e13
@jesseleite
There was never a constructor in this class.
22bc5ae
@jesseleite
Check commonmark version without composer lock file, like we're doing…
67b368d 
… in `Manager` now.
@jesseleite
Have LegacyParser extend Parser to clean up duplication and confi…
cf7bd3b 
…g handling.
@jesseleite
Merge branch 'master' of https://github.com/statamic/cms into laravel…
00daab9 
…-9-compatibility
@jesseleite
Refactor AssetContainer::accessible() to go through filesystem conf…
1a78b83 
…ig, since it's no longer available through flysystem.
@jesseleite
Refactor AssetContainer::listContents() to output normalized payloa…
72144f8 
…ds between flysystem 1.x and 3.x.
@jesseleite
Pass AssetContainerTest again.
3fd5670
@jesseleite
Pass AssetQueryBuilderTest again.
1b35487
@jesseleite
Add prefixPath() helper, since getPathPrefix() is no longer avail…
9ca09f6 
…able through flysystem.
@jesseleite
Pass AttributesTest and DimensionsTest again.
dec34ef
@jesseleite
These were never being used.
f894fe9
@jesseleite
Make AugmentedCollection::jsonSerialize() compatible with parent.
25eefbb
@jesseleite
Normalizing flysystem meta, since getMetadata() no longer exists.
fe6619c
@jesseleite
More getPathPrefix() refactorings.
3ed38c2
@jesseleite
Fix merging of array data when meta returns false due to missing file.
92c711b
@jesseleite
Use path() helper on disk instead of hardcoding to pass moar tests.
2f7cd30
@jesseleite
Get normalized meta data with less flysystem API calls.
7ee618f
@jesseleite
Clean up and better explain normalization.
176718a
@jesseleite
Pass AssetRepositoryTest by setting config at laravel level.
0b99d2c
@jesseleite
We can still getConfig() from flysystem if we normalize it.
b7bdb6f
@jesseleite jesseleite mentioned this pull request Feb 7, 2022
Closed
@jesseleite jesseleite requested a review from jasonvarga February 8, 2022 16:44
@jasonvarga jasonvarga mentioned this pull request Feb 9, 2022
Merged
@jasonvarga jasonvarga mentioned this pull request Feb 14, 2022
Closed
@jesseleite jesseleite marked this pull request as ready for review February 20, 2022 05:27
@jasonvarga jasonvarga merged commit ed793af into master Feb 21, 2022
@jasonvarga jasonvarga deleted the laravel-9-compatibility branch February 21, 2022 18:25
@jesseleite jesseleite mentioned this pull request Mar 8, 2022
Merged
@duncanmcclean duncanmcclean mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonvarga jasonvarga Awaiting requested review from jasonvarga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesseleite @jasonvarga