Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to fix a race condition with full-measure Static Caching, where if multiple requests come in for a URL at the same time, they might all try to write to the same file at the same time, causing mangled HTML, like seen in #10829.
I haven't been able to replicate the issue on my sandbox site, but I have been able to replicate it on a site @robdekort provided, using
spatie/fork
to perform concurrent requests.To fix it, I've adjusted how we handle locking in the StaticCaching\Cache middleware, replicating how we do it elsewhere in the app. From my testing, it seems to fix the issue. 🤞We made some changes to the static cache locking code in #10607. However, from memory, when I was last debugging this issue, I could reproduce it even after reverting that PR.After some further testing, it seems like the original fix didn't actually fix the issue - I just got lucky. We've changed approach, see comment.
Fixes #10829.