Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Allow options without labels in the Button Group & Select fieldtypes #10336

Merged
merged 12 commits into from
Aug 9, 2024
Merged

[5.x] Allow options without labels in the Button Group & Select fieldtypes #10336

merged 12 commits into from
Aug 9, 2024

Commits on Jun 19, 2024

  1. Remove old validation rules from Button Group & Select fieldtypes 

    These rules were ensuring all options had keys.

Since these rules were added, #9834 was merged, which added key validation to the base array fieldtype.
    @duncanmcclean
    duncanmcclean committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    9771b23 View commit details
    Browse the repository at this point in the history

  2. The Array Fieldtype checks against null, not empty strings

    @duncanmcclean
    duncanmcclean committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    b69669e View commit details
    Browse the repository at this point in the history

  3. Drop "all options must have values" validation

    @duncanmcclean
    duncanmcclean committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    c07884b View commit details
    Browse the repository at this point in the history

  4. Add tests to ensure options can be configured without labels 

    For Button Group & Select fieldtypes
    @duncanmcclean
    duncanmcclean committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    5147f30 View commit details
    Browse the repository at this point in the history

  5. Improve the validation message

    @duncanmcclean
    duncanmcclean committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    99fe1e9 View commit details
    Browse the repository at this point in the history

  6. Remove duplicate

    @duncanmcclean
    duncanmcclean committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    c3aded6 View commit details
    Browse the repository at this point in the history

  7. Fix styling

    @duncanmcclean @github-actions
    duncanmcclean authored and github-actions[bot] committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    8a1f9e1 View commit details
    Browse the repository at this point in the history

  8. Add empty string keys to tests

    @duncanmcclean
    duncanmcclean committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    57e6955 View commit details
    Browse the repository at this point in the history

  9. These should have values, like the null examples

    @duncanmcclean
    duncanmcclean committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    4c8951d View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge branch '5.x' into fix/select-fieldtype-validation

    @duncanmcclean
    duncanmcclean committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1fb8740 View commit details
    Browse the repository at this point in the history

  2. use #[Test] instead of metadata

    @duncanmcclean
    duncanmcclean committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    db3805d View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Merge branch '5.x' into fix/select-fieldtype-validation

    @jasonvarga
    jasonvarga committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    45ac097 View commit details
    Browse the repository at this point in the history