[5.x] Prevent published toast when save failed

[simonerd]

fixes #10190

I've tried to stay as close as possible to the changes made in #9040 but needed some further adjustments. Specifically, Revisable::publishWorkingCopy() and Revisable::unpublishWorkingCopy() now return false if the entry save() function fails. While this seems reasonable to me, I haven't yet found out if there are any other places (apart from the PublishedEntriesController) that would need to be considered.

I have added translations for the "Couldn't (un)publish entry" toast message as far as my (non-german) language skills felt reliable enough.

[duncanmcclean]

We're no longer accepting fixes to 4.x, can you re-target this PR for 5.x?

[simonerd]

We're no longer accepting fixes to 4.x, can you re-target this PR for 5.x?

Ah, sorry, didn't think about that 🙈 The project this is relevant to is still on 4.x, hence the target. Looks like they've got another reason not to wait with the 5.x update 😁

I've re-targeted and merged 5.x, will see if more changes are required.

[simonerd]

@duncanmcclean done for now

Still on the 4.x branch I already realised that the publish/unpublish actions also don't show any errors if saving fails. I've added a way of letting an action fail and optionally add a message that will be shown in the error toast.

Additionally, I was not quite happy with the handling of the action modal. So far, if the action was not successful, the confirmation modal would still be shown and an error toast would pop up. This kind of suggests that something went technically wrong, as the interface is stuck – similar to when an ajax error occurres. I felt like it would be more appropriate if the modal closes, but the error toast doesn't just give you a generic "action failed" answer. To get there, I introduced a status information to the ActionController response, and adjusted the modal handling based on that status. Errors because of missing auth or something else still leave the modal open, while unsuccessful publish/unpublish actions close the modal and show an error toast.

[duncanmcclean]

Still on the 4.x branch I already realised that the publish/unpublish actions also don't show any errors if saving fails. I've added a way of letting an action fail and optionally add a message that will be shown in the error toast.

Can you open a separate pull request with these changes, since they're unrelated to the original issue?

[simonerd]

I've split up the changes into two new PRs:

• [5.x] Prevent published toast when save failed #10263 implements the changes initially targeted above
• [5.x] Improve feedback when action fails #10264 implements the follow-up changes handling the feedback of failed actions