Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Remove legacy code that likely caused issues typing 'f' in asset file rename field #10777

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

steveparks
Copy link
Contributor

Fixes #10776

@925dk identified the likely cause of the reported issue as being this small piece of code 'leftover from the filter refactor'.

This PR removes that code.

I am a novice Statamic contributor so this will need thorough double-checking, but I haven't seen any other issues in my testing as a result of this change.

@jasonvarga
Copy link
Member

jasonvarga commented Sep 6, 2024

Confirmed.
The toggleable filter pane was added in #7589 which is where the key binding was added.
The feature was removed in #8001 but the key binding was left behind.

Thanks!

@jasonvarga jasonvarga merged commit a1160e6 into statamic:5.x Sep 6, 2024
16 checks passed
@steveparks
Copy link
Contributor Author

Wow, thanks for such speedy review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5.x] Letter 'f' cannot be typed in Asset file rename modal in some cases
2 participants