[5.x] Allow options without labels in the Button Group & Select fieldtypes #10336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These rules were ensuring all options had keys. Since these rules were added, #9834 was merged, which added key validation to the base array fieldtype.
For Button Group & Select fieldtypes
jasonvarga
approved these changes
Aug 9, 2024
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where it wasn't possible to add options without labels in the Button Group & Select fieldtypes, even though the UI indicated it should have been possible.
This worked fine previously. However, in #9834, we changed how we handle validating Array fields so it forces both keys and values to be set.
This change was an oversight, since there are cases, like this one, where you want the value to be optional
This PR removes the "force values" validation from the Array fieldtype, removes the duplicated "force keys" validation from the Button Group & Select option fields (since the Array field does that for us now) and adds tests to ensure options can be configured without labels.
Fixes #10323.